From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbdJDSks (ORCPT ); Wed, 4 Oct 2017 14:40:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59688 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbdJDSkq (ORCPT ); Wed, 4 Oct 2017 14:40:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 834F1793F5 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com Message-ID: <1507142443.46071.0.camel@redhat.com> Subject: Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value From: Doug Ledford To: Colin King , Lijun Ou , Wei Hu , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Oct 2017 14:40:43 -0400 In-Reply-To: <20170929201308.4704-1-colin.king@canonical.com> References: <20170929201308.4704-1-colin.king@canonical.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 04 Oct 2017 18:40:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-09-29 at 21:13 +0100, Colin King wrote: > From: Colin Ian King > > For the case where hr_qp->state == IB_QPS_RESET, an uninitialized > value in ret is being returned by function hns_roce_v2_query_qp. > Fix this by setting ret to 0 for this specific return condition. > > Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable") > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD