From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751256AbdJDTWa (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 15:22:30 -0400
Received: from mga01.intel.com ([192.55.52.88]:61643 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751195AbdJDTW3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 15:22:29 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,478,1500966000"; 
   d="scan'208";a="159438422"
Message-ID: <1507144946.14461.19.camel@tzanussi-mobl.amr.corp.intel.com>
Subject: Re: [PATCH v3 16/33] tracing: Generalize per-element hist trigger
 data
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org,
        vedang.patel@intel.com, bigeasy@linutronix.de, joel.opensrc@gmail.com,
        joelaf@google.com, mathieu.desnoyers@efficios.com,
        baohong.liu@intel.com, rajvi.jingar@intel.com,
        linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Date: Wed, 04 Oct 2017 14:22:26 -0500
In-Reply-To: <20171004133414.4840c351@gandalf.local.home>
References: <cover.1506105131.git.tom.zanussi@linux.intel.com>
         <18c12e2cd12243914d9cc98909c6720da084f3bd.1506105131.git.tom.zanussi@linux.intel.com>
         <20171004133414.4840c351@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-10-04 at 13:34 -0400, Steven Rostedt wrote:
> On Fri, 22 Sep 2017 14:59:56 -0500
> Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
> 
> > @@ -1742,7 +1746,8 @@ static void hist_trigger_stacktrace_print(struct seq_file *m,
> >  			seq_printf(m, "%s: [%llx] %-55s", field_name,
> >  				   uval, str);
> >  		} else if (key_field->flags & HIST_FIELD_FL_EXECNAME) {
> > -			char *comm = elt->private_data;
> > +			struct hist_elt_data *elt_data = elt->private_data;
> 
> Weren't we going to add a "if (WARN_ON_ONCE(!elt_data)) return;" here?
> 

This I did miss, will update ;-)

Tom

> -- Steve
> 
> > +			char *comm = elt_data->comm;
> >  
> >  			uval = *(u64 *)(key + key_field->offset);
> >  			seq_printf(m, "%s: %-16s[%10llu]", field_name,
> > --