From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751369AbdJDU0s (ORCPT ); Wed, 4 Oct 2017 16:26:48 -0400 Received: from ucol19pa12.eemsg.mail.mil ([214.24.24.85]:17230 "EHLO ucol19pa12.eemsg.mail.mil" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbdJDU0r (ORCPT ); Wed, 4 Oct 2017 16:26:47 -0400 X-Greylist: delayed 330 seconds by postgrey-1.27 at vger.kernel.org; Wed, 04 Oct 2017 16:26:47 EDT X-IronPort-AV: E=Sophos;i="5.42,478,1500940800"; d="scan'208";a="404317696" Message-ID: <1507148778.1491.10.camel@tycho.nsa.gov> Subject: Re: [PATCH 1/2] selinux: fix build warning by removing the unused sid variable From: Stephen Smalley To: Corentin Labbe , paul@paul-moore.com, eparis@parisplace.org, james.l.morris@oracle.com, serge@hallyn.com Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov Date: Wed, 04 Oct 2017 16:26:18 -0400 In-Reply-To: <20171004183218.4786-1-clabbe.montjoie@gmail.com> References: <20171004183218.4786-1-clabbe.montjoie@gmail.com> Organization: National Security Agency Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote: > This patch remove the unused variable sid > This fix the following build warning: > security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not > used [-Wunused-but-set-variable] > > Signed-off-by: Corentin Labbe Acked-by: Stephen Smalley > --- >  security/selinux/hooks.c | 3 +-- >  1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index f5d304736852..8507a56f85e4 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -2918,13 +2918,12 @@ static int selinux_inode_init_security(struct > inode *inode, struct inode *dir, >  { >   const struct task_security_struct *tsec = > current_security(); >   struct superblock_security_struct *sbsec; > - u32 sid, newsid, clen; > + u32 newsid, clen; >   int rc; >   char *context; >   >   sbsec = dir->i_sb->s_security; >   > - sid = tsec->sid; >   newsid = tsec->create_sid; >   >   rc = selinux_determine_inode_label(current_security(),