From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751335AbdJDUcS (ORCPT ); Wed, 4 Oct 2017 16:32:18 -0400 Received: from ucol19pa10.eemsg.mail.mil ([214.24.24.83]:24492 "EHLO UCOL19PA10.eemsg.mail.mil" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbdJDUcR (ORCPT ); Wed, 4 Oct 2017 16:32:17 -0400 X-IronPort-AV: E=Sophos;i="5.42,478,1500940800"; d="scan'208";a="348335356" Message-ID: <1507148872.1491.11.camel@tycho.nsa.gov> Subject: Re: [PATCH 2/2] selinux: fix build warning From: Stephen Smalley To: Corentin Labbe , paul@paul-moore.com, eparis@parisplace.org, james.l.morris@oracle.com, serge@hallyn.com Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov Date: Wed, 04 Oct 2017 16:27:52 -0400 In-Reply-To: <20171004183218.4786-2-clabbe.montjoie@gmail.com> References: <20171004183218.4786-1-clabbe.montjoie@gmail.com> <20171004183218.4786-2-clabbe.montjoie@gmail.com> Organization: National Security Agency Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote: > This patch make selinux_task_prlimit() static since it is not used > anywhere else. > This fix the following build warning: > security/selinux/hooks.c:3981:5: warning: no previous prototype for > 'selinux_task_prlimit' [-Wmissing-prototypes] > > Signed-off-by: Corentin Labbe Acked-by: Stephen Smalley > --- >  security/selinux/hooks.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 8507a56f85e4..b8a022f4b4a7 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct > task_struct *p) >       PROCESS__GETSCHED, NULL); >  } >   > -int selinux_task_prlimit(const struct cred *cred, const struct cred > *tcred, > -  unsigned int flags) > +static int selinux_task_prlimit(const struct cred *cred, const > struct cred *tcred, > + unsigned int flags) >  { >   u32 av = 0; >