From: Joe Perches <joe@perches.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>,
Suniel Mahesh <sunil.m@techveda.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
karthik@techveda.org
Subject: Re: [PATCH] staging: ccree: local variable "dev" not required
Date: Thu, 05 Oct 2017 11:00:31 -0700 [thread overview]
Message-ID: <1507226431.4434.37.camel@perches.com> (raw)
In-Reply-To: <CAOtvUMc3oVFxpgrj9i26_ETCG1CAr0Kj=77Lc2xVNdEPii-RkQ@mail.gmail.com>
On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote:
> On Wed, Oct 4, 2017 at 10:12 PM, <sunil.m@techveda.org> wrote:
> > There is no need to create a local pointer variable "dev" and
> > pass it various API's, instead use plat_dev which is enumerated
> > by platform core on successful probe.
[]
> I'm sorry but I don't understand what is the problem you are trying to solve or
> what is the improvement suggested.
>
> Why is having a local variable undesirable? I think having it makes
> the code more readable, not less.
IMO: The local variable is _not_ undesirable.
It does make the code more readable and
shortens line lengths too.
next prev parent reply other threads:[~2017-10-05 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 19:12 sunil.m
2017-10-05 7:07 ` Gilad Ben-Yossef
2017-10-05 18:00 ` Joe Perches [this message]
2017-10-06 4:07 ` Suniel Mahesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507226431.4434.37.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=karthik@techveda.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunil.m@techveda.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome