From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbdJETyc (ORCPT ); Thu, 5 Oct 2017 15:54:32 -0400 Received: from smtprelay0046.hostedemail.com ([216.40.44.46]:45409 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751405AbdJETya (ORCPT ); Thu, 5 Oct 2017 15:54:30 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2198:2199:2393:2538:2553:2559:2562:2694:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6119:6742:7903:7974:10004:10400:10848:11232:11658:11914:12043:12740:12760:12895:13069:13071:13149:13230:13311:13357:13439:14096:14097:14180:14181:14659:14721:21060:21080:21325:21627:30054:30060:30067:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: night69_26d394c91b92e X-Filterd-Recvd-Size: 3134 Message-ID: <1507233265.4434.45.camel@perches.com> Subject: Re: [PATCH] coccinelle: api: detect duplicate chip data arrays From: Joe Perches To: Liam Breck Cc: Julia Lawall , Masahiro Yamada , Sebastian Reichel , Pali =?ISO-8859-1?Q?Roh=E1r?= , Linux PM mailing list , kernel-janitors@vger.kernel.org, Gilles Muller , Nicolas Palix , cocci@systeme.lip6.fr, Linux Kernel Mailing List , kbuild test robot Date: Thu, 05 Oct 2017 12:54:25 -0700 In-Reply-To: References: <1506861768-5734-1-git-send-email-Julia.Lawall@lip6.fr> <1507230959.4434.39.camel@perches.com> <1507231856.4434.41.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-10-05 at 12:46 -0700, Liam Breck wrote: > Hi Joe, > > On Thu, Oct 5, 2017 at 12:30 PM, Joe Perches wrote: > > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: > > > On Thu, 5 Oct 2017, Joe Perches wrote: > > > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > > > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall : > > > > > > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > > > > > > > within a single structure. It is currently specific to the file > > > > > > > drivers/power/supply/bq27xxx_battery.c. > > > > > > > Signed-off-by: Julia Lawall > > > > > > > > > > > > Applied to linux-kbuild/misc. > > > > > > > > > > Thanks for picking it up. > > > > > > > > If it is specific to one file, why not just run it > > > > and post the resultant patch? Why have it in tree? > > > > > > I guess that they anticipate that the data may change in the future? > > > > Aren't you the script author Julia? Who is the "they"? > > > > I think having a script for a single file unnecessary. > > Sebastian Reichel, the power-supply maintainer, requested this script. > I previously implemented this as a run-time check within ifdef DEBUG, > but that was rejected. Hi Liam. If you are the author of the script, you should also have a sign-off/from here right? This also has a copyright of Inria and Julia Lawall which, if you are the author, doesn't seem appropriate. cheers, Joe