From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: p.zabel@pengutronix.de, richard.leitner@skidata.com,
srinivas.kandagatla@linaro.org, axel.lin@ingics.com,
ping.bai@nxp.com, d.schultz@phytec.de, peng.fan@nxp.com,
van.freenix@gmail.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Subject: [PATCH v2 5/7] nvmem: imx-ocotp: Add i.MX7D timing write clock setup support
Date: Sun, 8 Oct 2017 23:41:20 +0100 [thread overview]
Message-ID: <1507502482-22518-6-git-send-email-pure.logic@nexus-software.ie> (raw)
In-Reply-To: <1507502482-22518-1-git-send-email-pure.logic@nexus-software.ie>
This patch adds logic to correctly setup the write timing parameters
when blowing an OTP fuse for the i.MX7S/D.
Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support")
Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
---
drivers/nvmem/imx-ocotp.c | 65 ++++++++++++++++++++++++++++++++++++++---------
1 file changed, 53 insertions(+), 12 deletions(-)
diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
index 74c2f15..f80aee9 100644
--- a/drivers/nvmem/imx-ocotp.c
+++ b/drivers/nvmem/imx-ocotp.c
@@ -51,16 +51,12 @@
#define IMX_OCOTP_BM_CTRL_REL_SHADOWS 0x00000400
#define DEF_RELAX 20 /* > 16.5ns */
+#define DEF_FSOURCE 1001
#define IMX_OCOTP_WR_UNLOCK 0x3E770000
#define IMX_OCOTP_READ_LOCKED_VAL 0xBADABADA
static DEFINE_MUTEX(ocotp_mutex);
-struct ocotp_params {
- unsigned int nregs;
- unsigned int bank_address_words;
-};
-
struct ocotp_priv {
struct device *dev;
struct clk *clk;
@@ -69,6 +65,12 @@ struct ocotp_priv {
struct nvmem_config *config;
};
+struct ocotp_params {
+ unsigned int nregs;
+ unsigned int bank_address_words;
+ void (*set_timing)(struct ocotp_priv *priv);
+};
+
static int imx_ocotp_wait_for_busy(void __iomem *base, u32 flags)
{
int count;
@@ -193,6 +195,25 @@ static void imx_ocotp_set_imx6_timing(struct ocotp_priv *priv)
writel(timing, priv->base + IMX_OCOTP_ADDR_TIMING);
}
+static void imx_ocotp_set_imx7_timing(struct ocotp_priv *priv)
+{
+ unsigned long clk_rate = 0;
+ unsigned long fsource, strobe_prog;
+ u32 timing = 0;
+
+ /* i.MX 7Solo Applications Processor Reference Manual, Rev. 0.1
+ * 6.4.3.3
+ */
+ clk_rate = clk_get_rate(priv->clk);
+ fsource = DIV_ROUND_UP(((clk_rate / 1000) * DEF_FSOURCE), 1000000) + 1;
+ strobe_prog = ((clk_rate * 10) / 1000000) + 1;
+
+ timing = strobe_prog & 0x00000FFF;
+ timing |= (fsource << 12) & 0x000FF000;
+
+ writel(timing, priv->base + IMX_OCOTP_ADDR_TIMING);
+}
+
static int imx_ocotp_write(void *context, unsigned int offset, void *val,
size_t bytes)
{
@@ -219,7 +240,7 @@ static int imx_ocotp_write(void *context, unsigned int offset, void *val,
}
/* Setup the write timing values */
- imx_ocotp_set_imx6_timing(priv);
+ priv->params->set_timing(priv);
/* 47.3.1.3.2
* Check that HW_OCOTP_CTRL[BUSY] and HW_OCOTP_CTRL[ERROR] are clear.
@@ -371,12 +392,32 @@ static struct nvmem_config imx_ocotp_nvmem_config = {
.reg_write = imx_ocotp_write,
};
-static const struct octop_params params[] = {
- { .nregs = 128, .bank_address_words = 0 },
- { .nregs = 64, .bank_address_words = 0 },
- { .nregs = 128, .bank_address_words = 0 },
- { .nregs = 128, .bank_address_words = 0 },
- { .nregs = 64, .bank_address_words = 4 },
+static const struct ocotp_params params[] = {
+ {
+ .nregs = 128,
+ .bank_address_words = 0,
+ .set_timing = imx_ocotp_set_imx6_timing,
+ },
+ {
+ .nregs = 64,
+ .bank_address_words = 0,
+ .set_timing = imx_ocotp_set_imx6_timing,
+ },
+ {
+ .nregs = 128,
+ .bank_address_words = 0,
+ .set_timing = imx_ocotp_set_imx6_timing,
+ },
+ {
+ .nregs = 128,
+ .bank_address_words = 0,
+ .set_timing = imx_ocotp_set_imx6_timing,
+ },
+ {
+ .nregs = 64,
+ .bank_address_words = 4,
+ .set_timing = imx_ocotp_set_imx7_timing,
+ },
};
static const struct of_device_id imx_ocotp_dt_ids[] = {
--
2.7.4
next prev parent reply other threads:[~2017-10-08 22:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 22:41 [PATCH v2 0/7] Fix i.MX7D OCOTP write support Bryan O'Donoghue
2017-10-08 22:41 ` [PATCH v2 1/7] nvmem: imx-ocotp: Restrict OTP write to IMX6 processors Bryan O'Donoghue
2017-10-08 22:41 ` [PATCH v2 2/7] nvmem: imx-ocotp: Pass parameters via a struct Bryan O'Donoghue
2017-10-08 22:41 ` [PATCH v2 3/7] nvmem: imx-ocotp: Add support for banked OTP addressing Bryan O'Donoghue
2017-10-09 9:07 ` kbuild test robot
2017-10-09 9:22 ` kbuild test robot
2017-10-08 22:41 ` [PATCH v2 4/7] nvmem: imx-ocotp: Move i.MX6 write clock setup to dedicated function Bryan O'Donoghue
2017-10-08 22:41 ` Bryan O'Donoghue [this message]
2017-10-08 22:41 ` [PATCH v2 6/7] nvmem: imx-ocotp: Enable i.MX7D OTP write support Bryan O'Donoghue
2017-10-08 22:41 ` [PATCH v2 7/7] nvmem: imx-ocotp: Update module description Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507502482-22518-6-git-send-email-pure.logic@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=axel.lin@ingics.com \
--cc=d.schultz@phytec.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=richard.leitner@skidata.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=van.freenix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®