From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751838AbdJJEhw (ORCPT ); Tue, 10 Oct 2017 00:37:52 -0400 Received: from smtprelay0082.hostedemail.com ([216.40.44.82]:45279 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750734AbdJJEhu (ORCPT ); Tue, 10 Oct 2017 00:37:50 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3873:3874:4321:5007:7903:10004:10400:10848:11026:11232:11658:11914:12043:12048:12438:12740:12760:12895:13069:13255:13311:13357:13439:14180:14659:14721:21060:21080:21433:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: sleep74_270423198b024 X-Filterd-Recvd-Size: 1961 Message-ID: <1507610265.3552.20.camel@perches.com> Subject: Re: [PATCH] thermal/intel_powerclamp: pr_err()/pr_info() strings should end with newlines From: Joe Perches To: Daniel Lezcano , Arvind Yadav , rui.zhang@intel.com, edubezval@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 09 Oct 2017 21:37:45 -0700 In-Reply-To: <7555b065-f4de-2988-283b-b6800ce189ab@linaro.org> References: <277b8d12fc6980ec2ffd039a872f681ec0e49c19.1507549738.git.arvind.yadav.cs@gmail.com> <7555b065-f4de-2988-283b-b6800ce189ab@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-10-09 at 14:33 +0200, Daniel Lezcano wrote: > On 09/10/2017 13:51, Arvind Yadav wrote: > > pr_err()/pr_info() messages should end with a new-line to avoid > > other messages being concatenated. [] > > diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c > > @@ -675,13 +675,13 @@ static int __init powerclamp_probe(void) > > { > > > > if (!x86_match_cpu(intel_powerclamp_ids)) { > > - pr_err("CPU does not support MWAIT"); > > + pr_err("CPU does not support MWAIT\n"); [etc...] > Hi Arvind, > > you are sending these fixes for all the drivers around. There is a way > to fix this once and for all: use the coccinelle tools [1], add the > script in the changelog with a big patchset and add the script in the > coccinelle scripts directory [2]. That can't work as any printk without a newline termination could be followed by a printk(KERN_CONT/pr_cont( in another function. All of these must be hand-verified.