From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932181AbdJJIWh (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Oct 2017 04:22:37 -0400
Received: from mailgw02.mediatek.com ([218.249.47.111]:43509 "EHLO
        mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S932117AbdJJIWf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Oct 2017 04:22:35 -0400
X-UUID: 492c5131b8c14b6a97fbf66004a661fa-20171010
Message-ID: <1507623748.19789.10.camel@mhfsdcap03>
Subject: Re: [PATCH v3 01/12] mmc: mediatek: add support of mt2701/mt2712
From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
CC: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, yong mao <yong.mao@mediatek.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        "Heiner Kallweit" <hkallweit1@gmail.com>, Phong LE <ple@baylibre.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>
Date: Tue, 10 Oct 2017 16:22:28 +0800
In-Reply-To: <CAPDyKFppTCdaMizSGTjrfgsbMuHCsNi+knHVf9ibxgrAQ0GD2w@mail.gmail.com>
References: <1507604480-23246-1-git-send-email-chaotian.jing@mediatek.com>
         <1507604480-23246-2-git-send-email-chaotian.jing@mediatek.com>
         <CAPDyKFrqv5tt8Exq1msUBbMEROam2c+YnStazsf5SPj-NLrGSg@mail.gmail.com>
         <1507620951.19789.7.camel@mhfsdcap03>
         <CAPDyKFppTCdaMizSGTjrfgsbMuHCsNi+knHVf9ibxgrAQ0GD2w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2017-10-10 at 10:09 +0200, Ulf Hansson wrote:
> On 10 October 2017 at 09:35, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> > On Tue, 2017-10-10 at 09:26 +0200, Ulf Hansson wrote:
> >> [...]
> >>
> >> > +
> >> > +static const struct of_device_id msdc_of_ids[] = {
> >> > +       { .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat},
> >> > +       { .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat},
> >> > +       { .compatible = "mediatek,mt2701-mmc", .data = &mt2701_compat},
> >> > +       { .compatible = "mediatek,mt2712-mmc", .data = &mt2712_compat},
> >> > +       {}
> >> > +};
> >> > +MODULE_DEVICE_TABLE(of, msdc_of_ids);
> >>
> >> As already stated in the other reply. These new compatible changes
> >> needs to be discussed and acked before the driver starts using them.
> >>
> >> In other words, make patch3 to precede this one.
> > but, then there will have a probe issue as mentioned in previous mail
> > list. that's why I separate the binding file changes to 2 patches.
> 
> That sounds seriously wrong. Aren't the bindings backwards compatible?
> 
> Kind regards
> Uffe

As Matthias mentioned before:
"
>> NAK, this has to be:
>> You have to add the fallback compatible ("mediatek,mt8135-mmc") to
the binding
>> description as otherwise the driver does not get probed.
>>
>> Regards,
>> Matthias
"
the original compatible in driver is "mediatek,mt8135-mmc", so that if
drop "mediatek,mt8135-mmc" in bindings file(User may refer it and drop
"mediatek,mt8135-mmc" in their DTS), the driver will not get probed.