From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932569AbdJJWoy (ORCPT ); Tue, 10 Oct 2017 18:44:54 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:35466 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756166AbdJJWoq (ORCPT ); Tue, 10 Oct 2017 18:44:46 -0400 From: Parav Pandit To: joe@perches.com, apw@canonical.com Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, parav@mellanox.com, Brad Erickson Subject: [PATCH] checkpatch: Introduce check for format of Fixes line in commit log Date: Tue, 10 Oct 2017 17:44:27 -0500 Message-Id: <1507675467-24316-1-git-send-email-parav@mellanox.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch introduces a format check for 'Fixes' line in commit log for 12 characters commit id and format for Fixes as ("..."). Its created against linux-rdma Doug's tree [1]. [1] git://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git Signed-off-by: Parav Pandit Signed-off-by: Brad Erickson --- scripts/checkpatch.pl | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index dd2c262..7d933e4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2548,6 +2548,14 @@ sub process { "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr); } +# Check for incorrect format for Fixes line in commit log + if ($in_commit_log && $line =~ /^\s*Fixes:/i) { + if ($line !~ /^\s*Fixes: [a-z0-9]{12} \(\".*?\"\)$/i) { + ERROR("FIXES_FORMAT", + "Follow format of Fixes: <12 characters commit id> (\"...\")\n" . $herecurr); + } + } + # Check if the commit log is in a possible stack dump if ($in_commit_log && !$commit_log_possible_stack_dump && ($line =~ /^\s*(?:WARNING:|BUG:)/ || -- 1.8.3.1