From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932713AbdJKDKy (ORCPT ); Tue, 10 Oct 2017 23:10:54 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:64243 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756239AbdJKDJt (ORCPT ); Tue, 10 Oct 2017 23:09:49 -0400 X-AuditID: b6c32a37-c8dff70000001076-90-59dd8b7bda72 From: Chanwoo Choi To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com Cc: rafael.j.wysocki@intel.com, chanwoo@kernel.org, inki.dae@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v3 5/8] PM / devfreq: Get the available next frequency on update_devfreq() Date: Wed, 11 Oct 2017 12:09:21 +0900 Message-id: <1507691364-3899-6-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1507691364-3899-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsWy7bCmrm51991Ig8VPhC0m3rjCYnH9y3NW i0n3J7BYnG16w25xedccNovPvUcYLW43rmCzeLziLbsDh8fiPS+ZPDat6mTz6NuyitHj8ya5 AJaoVJuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoDOU FMoSc0qBQgGJxcVK+nY2RfmlJakKGfnFJbZK0YaGRnqGBuZ6RkZGeibGsVZGpkAlCakZi1ev Zito561Y9voDcwPjQ64uRk4OCQETiY7mb0xdjFwcQgI7GCWmrl7CCOF8Z5R4v+4fK0zVzJNr oKp2M0rM3veBDcL5wSjR0zKXHaSKTUBLYv+LG2wgtohAgETn2lVgHcwCTYwS++/dACsSFoiR ODCzEcjm4GARUJVobJMCMXkFXCR67vNBLJOT+LDnEVg1p4CrxORZp9hBxkgITGCTWLz+BAtE kYvE1EU3mCFsYYlXx7eAjZQQkJa4dNQWor6dUWLznHssEE4Ho8T9lY1Q7xhLnOpqZAKxmQX4 JN597WGFaOaV6GgTgijxkNjw4jkTRNhRYvZSJ4h/ZzBKLO9rZZ/AKLWAkWEVo1hqQXFuemqx YYGxXnFibnFpXrpecn7uJkZwKtEy38G44ZzPIUYBDkYlHt4dV+5ECrEmlhVX5h5ilOBgVhLh tSi8GynEm5JYWZValB9fVJqTWnyI0RQYMhOZpUST84FpLq8k3tDE0sDEzAiYFiwNDZXEecXW X4sQEkhPLEnNTk0tSC2C6WPi4JRqYOSSm345O3V6yTWbEy7h4q5MZ1o+p7grN6zJ5Nk813/D ngmlJ1o2nWOoCvU9bvmbT3Ayy9FNrLrsvdLR+y+mb/7w8HWK7MYfuVXTj8b1yQaWv9k6YfXc W81XONLurs+PnvfBqe5qj59rScsKlUvdpuoKFewbvu43ytKZyyOscen39cxyGUOlP0osxRmJ hlrMRcWJADxNWGo7AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmluLIzCtJLcpLzFFi42I5/e+xgG5V991Ig2+NNhYTb1xhsbj+5Tmr xaT7E1gszja9Ybe4vGsOm8Xn3iOMFrcbV7BZPF7xlt2Bw2PxnpdMHptWdbJ59G1ZxejxeZNc AEsUl01Kak5mWWqRvl0CV8bi1avZCtp5K5a9/sDcwPiQq4uRk0NCwERi5sk1TF2MXBxCAjsZ JaadesMI4fxglNjyeDoTSBWbgJbE/hc32EBsEQE/ie3z14MVMQs0MUos778FlhAWiJE4MLOR vYuRg4NFQFWisU0KxOQVcJHouc8HsUxO4sOeR+wgNqeAq8TkWafAbCGgkh+rXzJOYORZwMiw ilEytaA4Nz232KjAMC+1XK84Mbe4NC9dLzk/dxMjMIi2Hdbq28F4f0n8IUYBDkYlHl6B63ci hVgTy4orcw8xSnAwK4nwWhTejRTiTUmsrEotyo8vKs1JLT7EKM3BoiTOezvvWKSQQHpiSWp2 ampBahFMlomDU6qBMdsybG+Hem335OnlvUuqNpx5O+ksd1cja9rGqZMvNj4+uyVk0VML3TOd h9gsl/+5pLVx7m7m2AcCv1knz+BT9NPd/YCLp7Z1l+J+toaL14wPOfBwZKz+IPrDtug+X+PB Ew2zSw4dTzrm7nA6/1ji4oX+trfmqrr2q2z4cWHWu60XzgXcZMzrKldiKc5INNRiLipOBAAt mPsFHgIAAA== X-CMS-MailID: 20171011030947epcas1p1133ca20bb9356453c331751b3e3bba4b X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171011030947epcas1p1133ca20bb9356453c331751b3e3bba4b X-RootMTR: 20171011030947epcas1p1133ca20bb9356453c331751b3e3bba4b References: <1507691364-3899-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The update_devfreq() considers only user frequency (min_freq/max_freq) and the next target_freq provided by the governor. But, the commit a76caf55e5b35 ("thermal: Add devfreq cooling") is able to disable OPP as a cooling device. In result, the update_devfreq() have to consider the 'opp->available' status in order to decicde the next freq by the devfreq_recommended_opp(). Signed-off-by: Chanwoo Choi --- drivers/devfreq/devfreq.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 1c4b377cacfb..3b9662ffe603 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -255,6 +255,7 @@ static int devfreq_notify_transition(struct devfreq *devfreq, int update_devfreq(struct devfreq *devfreq) { struct devfreq_freqs freqs; + struct dev_pm_opp *opp; unsigned long freq, cur_freq; int err = 0; u32 flags = 0; @@ -273,7 +274,7 @@ int update_devfreq(struct devfreq *devfreq) return err; /* - * Adjust the frequency with user freq and QoS. + * Adjust the frequency with user freq, QoS and available freq. * * List from the highest priority * max_freq @@ -289,6 +290,12 @@ int update_devfreq(struct devfreq *devfreq) flags |= DEVFREQ_FLAG_LEAST_UPPER_BOUND; /* Use LUB */ } + opp = devfreq_recommended_opp(devfreq->dev.parent, &freq, flags); + if (IS_ERR(opp)) + return PTR_ERR(opp); + freq = dev_pm_opp_get_freq(opp); + dev_pm_opp_put(opp); + if (devfreq->profile->get_cur_freq) devfreq->profile->get_cur_freq(devfreq->dev.parent, &cur_freq); else -- 1.9.1