From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372AbdJKL0L (ORCPT ); Wed, 11 Oct 2017 07:26:11 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:24255 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbdJKL0J (ORCPT ); Wed, 11 Oct 2017 07:26:09 -0400 X-AuditID: b6c32a4b-585ff70000001095-3b-59ddffcff854 From: Maninder Singh To: akpm@linux-foundation.org, dvyukov@google.com, chris@chris-wilson.co.uk Cc: linux-kernel@vger.kernel.org, pankaj.m@samsung.com, a.sahrawat@samsung.com, Maninder Singh , Vaneet Narang Subject: [PATCH 1/1] stackdepot: ignore junk last entry in case of switch from user mode. Date: Wed, 11 Oct 2017 16:54:30 +0530 Message-Id: <1507721070-16810-1-git-send-email-maninder1.s@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFKsWRmVeSWpSXmKPExsWy7bCmpu75/3cjDbpPi1lc3J1qMWf9GjaL mw/PslpMeNjGbnF51xw2i8Pz21gs7r3ZymRx6ORcRgcOj5UftDwWbCr1ODHjN4tH35ZVjB6f N8kFsEal2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYA HaKkUJaYUwoUCkgsLlbSt7Mpyi8tSVXIyC8usVWKNjQ00jM0MNczMjLSMzGNtTIyBSpJSM04 9e8zW8Fi7oq7W5+wNzCu4+xi5OSQEDCRWLN/NksXIxeHkMBuRonV12dBOZ8YJVrbb7JCON8Y JY6cecUO03Lg/Qt2iMReRombJ9czQThfGCVW3W5jBKliE9CTWLVrDwuILSLgLfHzaAPYXGaB RYwSJ+/vZAJJCAtES3y/fYK5i5GDg0VAVeLUwmSQMK+Au8SMuxuYILbJSZw8NpkVwu5hk1h5 jgOkXELAReLsiSqIsLDEq+NboI6TknjZ3wZ2nIRAN6PEstNPmCCcGYwSK+7dY4aospd4cOMo O8ggZgFNifW79CFm2kpce6QBUsEswCfR+xukFSTMK9HRJgTRqCrRcnMD1DUeEs+/LIW60lHi 0bwnYI8ICcRKrLniPoFRdhbC+AWMjKsYJVMLinPTU4tNC4zzUsv1ihNzi0vz0vWS83M3MYLT lZb3DsZN53wOMQpwMCrx8O64cidSiDWxrLgy9xCjBAezkggv29+7kUK8KYmVValF+fFFpTmp xYcYTYGBN5FZSjQ5H5hK80riDU0sDUzMzMwNDQwsTZTEeY/tLI0UEkhPLEnNTk0tSC2C6WPi 4JRqYGyq+HBq5ze5rO0nFU0LOgN6E/hPhl2cLHhHdcaG1XI9bW1GQtod3xsclG90b363bu9V ry1F1d1PXthl+n09faE1p+nfQs3FX5cdsDltvraKP5b13ex1NlsPXrpx3+VkoeCGHbdXnq7b M515/fzgJ8axMad+RvjknNxziGlLb537Z5f5DNu+hK1QYinOSDTUYi4qTgQAX+Cgs20DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplluLIzCtJLcpLzFFi42LZdlhJTvfc/7uRBpe/CFtc3J1qMWf9GjaL mw/PslpMeNjGbnF51xw2i8Pz21gs7r3ZymRx6ORcRgcOj5UftDwWbCr1ODHjN4tH35ZVjB6f N8kFsEZx2aSk5mSWpRbp2yVwZZz695mtYDF3xd2tT9gbGNdxdjFyckgImEgceP+CvYuRi0NI YDejxK4zh9ggEtISP/+9Z4GwhSVW/nsOVfSJUWLRsl9gCTYBPYlVu/aA2SIC/hLvHk9kBCli FljGKDHj9mSgDg4OYYFIiSv7xUFMFgFViVMLk0HKeQXcJWbc3cAEMV9O4uSxyawTGHkWMDKs YpRMLSjOTc8tNiwwzEst1ytOzC0uzUvXS87P3cQIDiQtzR2Ml5fEH2IU4GBU4uEVuH4nUog1 say4MvcQowQHs5IIL9vfu5FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeZ/mHYsUEkhPLEnNTk0t SC2CyTJxcEo1MBqZXTdqmdq1V/dkJv+WSdGcW/mndPvpRd7dt/LE/vWzLRwWagazeDzeJ/RM rLn51BHVW4vXrr8xIyG9t7IsZNmh2UuZtq+b/cOZJ8Pl+cGzxQLCHHIckXyi5Zp6kw9wLVq/ 1GmKf3L9jdSJ85UN/8od3R5k9iacnS9f/vTFrpAjTU+/3AifYKHEUpyRaKjFXFScCADHtYsB IAIAAA== X-CMS-MailID: 20171011112606epcas5p2ff2b1b64d5037aeb5e0f97c9d17b8658 X-Msg-Generator: CA X-Sender-IP: 182.195.40.13 X-Local-Sender: =?UTF-8?B?TWFuaW5kZXIgU2luZ2gbU1JJLURlbGhpLVBsYXRmb3JtIFMv?= =?UTF-8?B?VyAxIFRlYW0b7IK87ISx7KCE7J6QG0xlYWQgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?TWFuaW5kZXIgU2luZ2gbU1JJLURlbGhpLVBsYXRmb3JtIFMv?= =?UTF-8?B?VyAxIFRlYW0bU2Ftc3VuZ8KgRWxlY3Ryb25pY3PCoBtMZWFkIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDJJRDAyODExNQ==?= Content-Type: text/plain; charset="utf-8" X-MTR: 20171011112606epcas5p2ff2b1b64d5037aeb5e0f97c9d17b8658 CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171011112606epcas5p2ff2b1b64d5037aeb5e0f97c9d17b8658 X-RootMTR: 20171011112606epcas5p2ff2b1b64d5037aeb5e0f97c9d17b8658 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Issue observed on ARM. Whenever there is switch from user mode, we end up with invalid last entry with some user space address as below:- save_stack+0x40/0xec __set_page_owner+0x2c/0x64 .... .... __handle_domain_irq+0x9c/0x130 gic_handle_irq+0x40/0x80 __irq_usr+0x4c/0x60 0xb6507818 So in this case last entry is not valid, which leads to allocated one more new frame for stackdepot although having all above frames exactly same. (It increases depot_index drastically) So its better to ignore that last frame in case of switch. save_stack+0x40/0xec __set_page_owner+0x2c/0x64 .... .... __handle_domain_irq+0x9c/0x130 gic_handle_irq+0x40/0x80 __irq_usr+0x4c/0x60 Signed-off-by: Vaneet Narang Signed-off-by: Maninder Singh --- lib/stackdepot.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index f87d138..bb35b2c 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -214,6 +214,11 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace, if (unlikely(trace->nr_entries == 0)) goto fast_exit; + if (trace->entries[trace->nr_entries - 1] < MODULES_VADDR) { + trace->entries[trace->nr_entries - 1] = ULONG_MAX; + trace->nr_entries--; + } + hash = hash_stack(trace->entries, trace->nr_entries); bucket = &stack_table[hash & STACK_HASH_MASK]; -- 1.9.1