From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752619AbdJKSsl (ORCPT ); Wed, 11 Oct 2017 14:48:41 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38599 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdJKSsj (ORCPT ); Wed, 11 Oct 2017 14:48:39 -0400 X-Google-Smtp-Source: AOwi7QBzSTW4ZP+hfG3yHjxPZjYrJ4+lrJUG9BZo5erbtWHyrSfPWLEoGtPgRPTlKnqbtV1thFiVVA== Message-ID: <1507747717.31614.28.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: next: arm64: LTP sendto01 test causes system crash in ilp32 mode From: Eric Dumazet To: Yury Norov Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Catalin Marinas , "David S. Miller" , Florian Westphal Date: Wed, 11 Oct 2017 11:48:37 -0700 In-Reply-To: <1507747313.31614.27.camel@edumazet-glaptop3.roam.corp.google.com> References: <20171011183522.tm2xxgzbdspjtsax@yury-thinkpad> <1507747313.31614.27.camel@edumazet-glaptop3.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-10-11 at 11:41 -0700, Eric Dumazet wrote: > On Wed, 2017-10-11 at 21:35 +0300, Yury Norov wrote: > > Hi all, > > > > It seems like next-20171009 with ilp32 patches crashes on LTP sendto01 test > > in sys_sendto() path, like this: > > Thanks for the report. > Probably caused by one of my recent patches, so I am taking a look. Yes, this was silly. Please test this fix : diff --git a/include/net/tcp.h b/include/net/tcp.h index 5a95e5886b55e03e4a8bfeac3506c657a4f97dde..15163454174babdcb465904f725b919268dd1bc7 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -1712,6 +1712,7 @@ static inline void tcp_insert_write_queue_before(struct sk_buff *new, static inline void tcp_unlink_write_queue(struct sk_buff *skb, struct sock *sk) { + tcp_skb_tsorted_anchor_cleanup(skb); __skb_unlink(skb, &sk->sk_write_queue); }