From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756553AbdJLQnP (ORCPT ); Thu, 12 Oct 2017 12:43:15 -0400 Received: from mga06.intel.com ([134.134.136.31]:3510 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753138AbdJLQnN (ORCPT ); Thu, 12 Oct 2017 12:43:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,366,1503385200"; d="scan'208";a="1205153720" From: Chintan Patel Cc: vinod.koul@intel.com, Chintan Patel , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Jeeja KP , "guneshwor.o.singh@intel.com" , Shreyas NC , Takashi Sakamoto , Ramesh Babu , Dharageswari R , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology loading Date: Thu, 12 Oct 2017 09:44:37 -0700 Message-Id: <1507826678-25509-1-git-send-email-chintan.m.patel@intel.com> X-Mailer: git-send-email 1.9.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In case of failure in loading customize topology firmware, dfw_sst.bin gets loaded. However, current log provides this message as error even after successfully falling back to default topology "dfw_sst.bin". Hence to convey proper message, changing log level and message. Signed-off-by: Chintan Patel --- Changes in v2: Addressing review comments from Takashi Iwai by changing loglevel as info sound/soc/intel/skylake/skl-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 22f768ca3c73..12f383fd7c39 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus) ret = request_firmware(&fw, skl->tplg_name, bus->dev); if (ret < 0) { - dev_err(bus->dev, "tplg fw %s load failed with %d\n", + dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin", skl->tplg_name, ret); ret = request_firmware(&fw, "dfw_sst.bin", bus->dev); if (ret < 0) { -- 1.9.1