From: alawang <alan.1.wang@nokia-sbell.com>
To: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
alawang <alan.1.wang@nokia-sbell.com>
Subject: [PATCH] of: dynamic: fix memory leak related to properties of __of_node_dup
Date: Fri, 13 Oct 2017 09:42:47 +0800 [thread overview]
Message-ID: <1507858967-40416-1-git-send-email-alan.1.wang@nokia-sbell.com> (raw)
It is possible a node was dynamically allocated but without any
property. The properies will be got from devices and added to the
node when devices got connected.
When release this node, all properties of which had been moved to
deadprops.
In this case, the properties in the deadprops list are never
deallocated.
Signed-off-by: alawang <alan.1.wang@nokia-sbell.com>
---
drivers/of/dynamic.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index 301b6db..465d43b 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -335,6 +335,10 @@ void of_node_release(struct kobject *kobj)
if (!of_node_check_flag(node, OF_DYNAMIC))
return;
+ if (!prop) {
+ prop = node->deadprops;
+ node->deadprops = NULL;
+ }
while (prop) {
struct property *next = prop->next;
kfree(prop->name);
--
2.6.2
next reply other threads:[~2017-10-13 1:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 1:42 alawang [this message]
2017-10-13 3:25 ` Lixin Wang
2017-10-13 20:47 ` Rob Herring
2017-10-14 0:59 ` Frank Rowand
2017-10-16 4:35 ` Wang, Alan 1. (NSB - CN/Hangzhou)
2017-10-17 14:03 ` Rob Herring
2017-10-17 4:20 ` [PATCH v2] " Lixin Wang
2017-10-19 9:40 ` [PATCH v3] " Lixin Wang
2017-10-19 23:26 ` Frank Rowand
2017-10-19 23:34 ` frowand.list
2017-10-20 1:59 ` [PATCH v4] " Lixin Wang
2017-10-20 18:12 ` Rob Herring
2017-10-23 3:19 ` [PATCH v5] " Lixin Wang
2017-10-23 5:16 ` Frank Rowand
2017-10-23 16:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507858967-40416-1-git-send-email-alan.1.wang@nokia-sbell.com \
--to=alan.1.wang@nokia-sbell.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®