From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753498AbdJMD0T (ORCPT ); Thu, 12 Oct 2017 23:26:19 -0400 Received: from mail-he1eur01on0131.outbound.protection.outlook.com ([104.47.0.131]:63552 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753292AbdJMD0R (ORCPT ); Thu, 12 Oct 2017 23:26:17 -0400 Authentication-Results: spf=pass (sender IP is 131.228.2.240) smtp.mailfrom=nokia-sbell.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=pass action=none header.from=nokia-sbell.com; X-HPESVCS-Source-Ip: 10.159.218.88 From: Lixin Wang To: Rob Herring , Frank Rowand CC: , , Lixin Wang Subject: [PATCH] of: dynamic: fix memory leak related to properties of __of_node_dup Date: Fri, 13 Oct 2017 11:25:18 +0800 Message-ID: <1507865118-27744-1-git-send-email-alan.1.wang@nokia-sbell.com> X-Mailer: git-send-email 2.6.2 In-Reply-To: <1507858967-40416-1-git-send-email-alan.1.wang@nokia-sbell.com> References: <1507858967-40416-1-git-send-email-alan.1.wang@nokia-sbell.com> X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:131.228.2.240;IPV:CAL;SCL:-1;CTRY:FI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(346002)(39860400002)(376002)(2980300002)(438002)(199003)(189002)(305945005)(50466002)(68736007)(356003)(52956003)(81166006)(5660300001)(8676002)(2906002)(81156014)(8936002)(26826003)(48376002)(103686004)(6666003)(189998001)(6266002)(50226002)(478600001)(22756006)(107886003)(97736004)(54906003)(5003940100001)(47776003)(16586007)(42186006)(316002)(33646002)(110136005)(106002)(39060400002)(53936002)(106466001)(2950100002)(46386002)(90966002)(45336002)(4326008)(86362001)(76176999)(36756003)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0701MB2973;H:mailrelay.int.nokia.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;VE1EUR03FT030;1:dUMspHI3Fq3r4l7xQqitvToVkWtAAJXqDhqSDBKNvzF+A+hLr7OLA0XGeWUI+NrLwPtj+xa1pVAo0I4s4ZYppCp4BqTNVxFH17r2Pb0JtykJmmxVFCRE2KMz0GPY7HkK MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 771a7d36-a4cf-4877-6e8d-08d511ea27c4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:VI1PR0701MB2973; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB2973;3:osB0NZpdAg3nzEiw44vOFSp7yZ6sghorieAmLKOr0YInBZ2xtLqifjkcjivWyUqcOZJlPl0UPe4GfNdG61Y/y/b8ZYDpySF0g5LYUbD8HtmkVpG/ALQ0liJ+1iaSFm5g3YEruB8EvIyGUFwjonbAZTS4pKLXKIz9LpTlm3p5Vn4u741TB0dMH8PfC6WBUiUMK2WyK/2jNkll8TPQ+q3gnuuT8lGUejvFUzkrNjulScgIgEz9MZJS5uoZwRk7OTZPRn+r/tDEOLucJ7lt5vbLdBGe3hvYA3e8tvvzvyqsHFfdwLCPU9mVfGKNqmZ3ZD5LdKi4bWLoDFiQyoQGf/gEHhF042RGDK2hnA/mubAZsdo=;25:DpwEmzZ0L/oB/XJ3sRMLg5AnJ7jOrtwtw9vb01QOrG12ndXWXxq4BN48wdmL2tFoXaLRSrSI1FRtpHFtxG4YdEtCP4yq+PkVr2aksM7cWa8ErqjjzCJHSPsNrKMbesxhnpritKdVkS1xnHDMvSTMlpiYodzn6T+CLM/Z6N8c5/oTw0n+5iTca5Sm5G07uLTNy1a2zaRcRjUlxJ8yakjmiOer10WO1S6DMP+DkDw8qTM5Yz/zv/3VMVbM7NY0DvOpAfSXRhfhFH1EJWiFIUQqZ3dhoucn3JMNawc6JekrB5mo6gF8IVpXe1LhRLK3w3jgnBCnymqFy/P9RLihjiBODw== X-MS-TrafficTypeDiagnostic: VI1PR0701MB2973: X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB2973;31:9TydU29fAFlj3fU7eempsEwZgMcTqedSBxR1r0oRpakdlqUwKH0B08A5Y6RzY10s2e6JXcaBGLSvbu5CNPKqodrAkmqgSl3glYiez6Ec8E3VSjWw7Fjvg5liVgtMk52yNUuVGwGtiJK79rBxywr67MHNvLWcUhsAJMuTP2o0LpMrm49Mj4AB3jhegV+SErl86KgCsyogiAtDEGq9/cMcr82Y5rHA4BR91B7FCQb6wgc=;20:AUTeMgJ6eYe6u55p1RhWLTagflVG5V7SpvayL8oSr4y//xZX/1bjHRWGFfFo8VxdL7L6S5ecw/nS+aJHFmrSju6LpTnLxBqRqjW2ywaNa+/EbcP818zJOPG/RZoo9u8DEZAsxTTTG/TZ4Fm2ZYOEhXDlLmh5j4y46I/YXcq4nt1M33jnCbVhlhV7Vq+UhFtNs2SG+aE8d5hkAhYlQIu+50Lvk1ToYp4aAEPbNp4gmRO5q8ctjbMSCUqUGrs4J/8nwQVjZGbSudso2OSI1Byhm6ShIB6ZIzqZ+wGWK27DYrf8Bg1E5IFa/cm3Z1MM8cCeDRs199bRq1p2Zx2ptPq2vll9pvWOYzZxJebQDZb8foy8c5UUQ8fkKCdHW8IA0z3JUuiiULpNYYWs/crPzl2RdMn6nbPuYdz/nHsBsQWjy/SqNuO2OFbfSjrh/4+meL+f0GyVr/zj3YiEZ0pbsLy7pxWntqIKOfKkbo2pqjLO3nIxLcgL6bXtwWo9YJ1okKmn3o8jcOqBr90kXq2paytUDUm0YwNNzFbnS1qSItvA8+WDDtI1T+GqpmG0zbXeBf3/TIqLE0NcpCffWG9k+oKtANwEih1Wslv0G5z++LCSeIs= X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93004095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0701MB2973;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0701MB2973; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB2973;4:wsCrACcTRimqtZaK8ugden2+ZYmLQkETEoxOzBdL1Hn8BKWiiNI10VwPse79wYUBxCR//7lRHax+YY2dMgi5vWNgY9ToeyxL/faaHsS1HzrqXeIQQWCLtKLywQcm32wLmgGGTkpoJmZRBqrgDcLBk+yxhJDfWclIAk4PqBM/451X8hNOyixt35cFM0XYFGwBTTfwoH4HggSkZYDi9D7pc+uL219YWpkt88HqwEwjS69jAT3P2fjZC7W1KihbDYYM X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0701MB2973;23:xQ/QwtjxlogVHjBylfc+nNOfbOippssVLn0HsVJ?= =?us-ascii?Q?Js+a80A7xy0fZdKNl7xtDF1hG4ng6Tvg8eOKqo+GRLl61elDwzkT2Ce2skFA?= =?us-ascii?Q?ULJfeg4fH6ODBbhCihH9CzF71WAud//fu4y1irg4v7dXIE2RegF9Kyp9eoPM?= =?us-ascii?Q?kbEnBl3Uu0vXhG4bzVUbxqdpeGSyIrwaRkZDvz0rZTFAv1+zMipAqf5nkJV1?= =?us-ascii?Q?48M0AQlukHDeJNnge7MHRGp5IPb30R8yHwoY+UEvcinQ2prTM4ijnQSDLLSx?= =?us-ascii?Q?CJVI56X5cS8QUHIoU4cu8ZuGHiHAi+0OkbU8Ayj2DJxU1g3vCLAZ5LchVjTx?= =?us-ascii?Q?dg0553uzQzSdREIsYOf3auEhnjX4fObrm6lFeUXymQxmlhh1BPU+J8AgbayW?= =?us-ascii?Q?VnoBa7/ZDdfAvyjNHVdad38/lEao4OgkarppZdObfVvo42Dn9RCbrxhofENL?= =?us-ascii?Q?NKddZnZYejL/pFi1nFINYYVCOURv//tFYEeISCOOyBXw1ebZ/INdlfxPHGUe?= =?us-ascii?Q?rDSyuhVIQUMLq33FJ8BLYB8yjO6PbHNeavWsgFY9AkxVdtOOxGhse5yteudx?= =?us-ascii?Q?Yp5lt7Ou1XK4BrI+2CWljN0UTNyp76/9va3OLyKWzsoEG0FtcjnkDozJ/jYz?= =?us-ascii?Q?x7ciO6n9hzILn1SKrGmV4yAQBFdF9UWy2AYNNmovceBYAupFkLk3HaqEHAB+?= =?us-ascii?Q?Y9NfFLKSg7bVT1ozQKHmn6hU82/T/9UDJmP+wfmK0/CLlQNXsnvsmrLcWG0P?= =?us-ascii?Q?+KmzSIEHhRL5/m5sDzgeimTjBdYKS9UTCYfqE/nXAPWBiQdIyh9Ci+1bb5MW?= =?us-ascii?Q?yJIhVhqkZK8bPI2GzKPvjELi0C1Ys/+21k4MreavK0sVBYl4QPsBFIVKqHRg?= =?us-ascii?Q?+hTQcT0TIS3yjxAnp4lqmGN/th1+EwAZJLfdwbD1zu3RWc6j8zBYLFppiVMw?= =?us-ascii?Q?teoXpBk9s8YjCfF1zpMFjHcgArKgM7cdPdVKNqzh7tqQNP7XpW8QyLhqS+h2?= =?us-ascii?Q?oy+a9EYBzlOvUtm4fT6Q2X1HA8WtPjWnYFyTxc1U6YgDSSOOnOgUSL+oL6Pd?= =?us-ascii?Q?xzpm+oemIjQLUU48LhQ1I/enRe/vOb+r8y3ViPaZVeEC2dKBXM9+3spwaNWX?= =?us-ascii?Q?3d9A2P+4er2kyVHhO5+FREri0fk35pwnYz1u72mkJ/4iGnj66AlyZvXoAA6o?= =?us-ascii?Q?+dXWmT3F4FWbWnmgebW9LmAe/zED1UzSdhGlK?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB2973;6:xZ6VKDO/GaRcKuIN+9Mx39p5XCDCU9iMwygOHf5G6K/uRvmbdMbA0kUfTjFQECPfaaXBB2IQC+a0ZxBKyRjfUNKLeiQTAKOYS6RDj46OKjbm0wB7b7DtPoE/VBdPA3ifxi7/IW3KpTO4qehWWT9hpuY0hdtRjlHi8vu5+dyv5iee2amTIy9763UgeDDvt6Tm4slb2iJ+ZeA01I0noKDGlsb1ept1C+s8d6m/GAel7dzB2nUHey5BIAkBkFxYhaIQCKvCwqKEMIWr3LegJHh/WqLzbIfoC/UZQ4PdDsPZU0DpxR5hE/W0bknE4VgESyxeReI3kyLo4VDLPSr94TzHPw==;5:Kw/csHvc7pkhtHV7jLHxMREzwTSOrXm/F7LWn2+RIuHXzmlKsk7LOlwanAglmZrvuULKgDbo9pojso1/y4KiZ9oqaCrNJ0L4NzzNnugUwQ/VN9eGOJocriStB27IPI7nSWRubqNoBu6FXShC4EMiY5cVbzwg37cOwskU3Wi/zxY=;24:g8L/qjJsUEnAQcoshfCfXC/vzVtb8Rv46J2pe6ZNka8j8T/oi8FsuLzyqD31nnUVLEKPi1yMfLBM8LXU3VWjGtFCZGP4zf1lEm2yeWlkGN0=;7:bpxC30B0lza5OFBmqll2fR0XhYzSgqR6Tp1KrtD7gwEDDcq/Ff1/tMponx5StUUlPreN8S2CbqYvosSFqxJhxkRcWKmvXFU3cOpKGS5TVT9RXutMxmAWrbJPH1BqeimXtBrP3u8KVerbOeKbQ4LLkgP9AYtQtqn3UJaPvA7Pf0MG26S+6WjM5pc8+wGuyVPkaHiAGqrRQel/rwD/35EEntVHmBJv09MMVF79VsN4tn8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nokia-sbell.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 03:26:12.8122 (UTC) X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5d471751-9675-428d-917b-70f44f9630b0;Ip=[131.228.2.240];Helo=[mailrelay.int.nokia.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB2973 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Sorry It was my fault that used the wrong sign off name in last email. Here I correct it. Thanks --- It is possible a node was dynamically allocated but without any property. The properies will be got from devices and added to the node when devices got connected. When release this node, all properties of which had been moved to deadprops. In this case, the properties in the deadprops list are never deallocated. Signed-off-by: Lixin Wang --- drivers/of/dynamic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c index 301b6db..465d43b 100644 --- a/drivers/of/dynamic.c +++ b/drivers/of/dynamic.c @@ -335,6 +335,10 @@ void of_node_release(struct kobject *kobj) if (!of_node_check_flag(node, OF_DYNAMIC)) return; + if (!prop) { + prop = node->deadprops; + node->deadprops = NULL; + } while (prop) { struct property *next = prop->next; kfree(prop->name); -- 2.6.2