From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757944AbdJMHuN (ORCPT ); Fri, 13 Oct 2017 03:50:13 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:17552 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756736AbdJMHsf (ORCPT ); Fri, 13 Oct 2017 03:48:35 -0400 X-AuditID: b6c32a46-acbff70000001153-38-59e06fd0b2dd From: Chanwoo Choi To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com Cc: rafael.j.wysocki@intel.com, chanwoo@kernel.org, inki.dae@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v4 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device Date: Fri, 13 Oct 2017 16:48:17 +0900 Message-id: <1507880904-31956-2-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1507880904-31956-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsWy7bCmue6F/AeRBr/Om1tMvHGFxeL6l+es FpPuT2CxONv0ht3i8q45bBafe48wWtxuXMFm8XjFW3YHDo/Fe14yeWxa1cnm0bdlFaPH501y ASxRqTYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QGco KZQl5pQChQISi4uV9O1sivJLS1IVMvKLS2yVog0NjfQMDcz1jIyM9EyMY62MTIFKElIzpr7q Zy04K1DxcNly9gbG57xdjJwcEgImEqdXTGTsYuTiEBLYwSjx4f9lKOc7o8Tsu7/ZYKrOzNvE BpHYwCix8/J1ZgjnB6PEq0u32UGq2AS0JPa/uAHWISIQING5dhUTSBGzQBOjxP57N8CKhAXC Je7O/8MMYrMIqEpMu70RLM4r4Crxdvoddoh1chIf9jwCszkF3CRuXb0OdpOEwAQ2idUT9zNC FLlIPFi4lBnCFpZ4dXwLVLO0xLNVG6Ea2hklNs+5xwLhdDBK3F/ZyApRZSxxqquRCcRmFuCT 6Dj8F6ibAyjOK9HRJgRR4iGx8PZ1Voiwo8TfAy4QL89klLj6cj37BEapBYwMqxjFUguKc9NT i40KjPSKE3OLS/PS9ZLzczcxghOKltsOxiXnfA4xCnAwKvHwClTdjxRiTSwrrsw9xCjBwawk wqvq+iBSiDclsbIqtSg/vqg0J7X4EKMpMHAmMkuJJucDk11eSbyhiaWBiZmZkbmZBTBBiPPW bbsWISSQnliSmp2aWpBaBNPHxMEp1cCYmy93Q09L+1FwxePamnih2ne/Zucd5Nr+2zbs4W+5 qpI5X3T7vsc8PN7nZXfjykqryGl7IkLSdhfaf53J+3J/actLIZaf2ywfG8gvDY2ICLx+/x/j 07W5le0/TC1D3zBLqRZzv+rb2F52inXp5FcqZWHrvpSaq6jcSg/dnhVp/lF13eaNk94psRRn JBpqMRcVJwIAhfsvDD4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplluLIzCtJLcpLzFFi42I5/e+xoO75/AeRBtfmm1hMvHGFxeL6l+es FpPuT2CxONv0ht3i8q45bBafe48wWtxuXMFm8XjFW3YHDo/Fe14yeWxa1cnm0bdlFaPH501y ASxRXDYpqTmZZalF+nYJXBlTX/WzFpwVqHi4bDl7A+Nz3i5GTg4JAROJM/M2sXUxcnEICaxj lHh75jU7hPODUWLBgSPMIFVsAloS+1/cYAOxRQT8JLbPX88IUsQs0MQosbz/FlhCWCBcYvbb eWANLAKqEtNub2QHsXkFXCXeTr/DDrFOTuLDnkdgNqeAm8Stq9cZQWwhoJq7Mx8xTmDkWcDI sIpRMrWgODc9t9iowCgvtVyvODG3uDQvXS85P3cTIzCQth3W6t/B+HhJ/CFGAQ5GJR7eHeX3 I4VYE8uKK3MPMUpwMCuJ8Kq6PogU4k1JrKxKLcqPLyrNSS0+xCjNwaIkzsuffyxSSCA9sSQ1 OzW1ILUIJsvEwSnVwNhq9bxTvfrQ54sfl9cqOQh86ZrhLSA5S8a6/M+8y9vXpwiq82b3/CuY HbFPNtQtw5FzwcUnV9YvOv7i2f6tidmBq4KXf+39ff1f/TTBDdGM2bpvZgixZS0Qv3LY+PuD 8MYbE1WWbWH/9Dvh2h7lHb902Vdz8t+x/7bz6yLztU4T7q1keZCfrs+lxFKckWioxVxUnAgA BMZGgCACAAA= X-CMS-MailID: 20171013074831epcas2p2d9120a18f746f2831057a1da1977394a X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171013074831epcas2p2d9120a18f746f2831057a1da1977394a X-RootMTR: 20171013074831epcas2p2d9120a18f746f2831057a1da1977394a References: <1507880904-31956-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Prior to that, the min/max_freq of the devfreq device are always zero before the user changes the min/max_freq through sysfs entries. It might make the confusion for the min/max_freq. This patch initializes the available min/max_freq by using the OPP during adding the devfreq device. Acked-by: MyungJoo Ham Signed-off-by: Chanwoo Choi --- drivers/devfreq/devfreq.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index a1c4ee818614..6a6f88bccdee 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -69,6 +69,34 @@ static struct devfreq *find_device_devfreq(struct device *dev) return ERR_PTR(-ENODEV); } +static unsigned long find_available_min_freq(struct devfreq *devfreq) +{ + struct dev_pm_opp *opp; + unsigned long min_freq = 0; + + opp = dev_pm_opp_find_freq_ceil(devfreq->dev.parent, &min_freq); + if (IS_ERR(opp)) + min_freq = 0; + else + dev_pm_opp_put(opp); + + return min_freq; +} + +static unsigned long find_available_max_freq(struct devfreq *devfreq) +{ + struct dev_pm_opp *opp; + unsigned long max_freq = ULONG_MAX; + + opp = dev_pm_opp_find_freq_floor(devfreq->dev.parent, &max_freq); + if (IS_ERR(opp)) + max_freq = 0; + else + dev_pm_opp_put(opp); + + return max_freq; +} + /** * devfreq_get_freq_level() - Lookup freq_table for the frequency * @devfreq: the devfreq instance @@ -559,6 +587,20 @@ struct devfreq *devfreq_add_device(struct device *dev, mutex_lock(&devfreq->lock); } + devfreq->min_freq = find_available_min_freq(devfreq); + if (!devfreq->min_freq) { + mutex_unlock(&devfreq->lock); + err = -EINVAL; + goto err_dev; + } + + devfreq->max_freq = find_available_max_freq(devfreq); + if (!devfreq->max_freq) { + mutex_unlock(&devfreq->lock); + err = -EINVAL; + goto err_dev; + } + dev_set_name(&devfreq->dev, "devfreq%d", atomic_inc_return(&devfreq_no)); err = device_register(&devfreq->dev); -- 1.9.1