From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758073AbdJMN0x (ORCPT ); Fri, 13 Oct 2017 09:26:53 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8038 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753438AbdJMN0w (ORCPT ); Fri, 13 Oct 2017 09:26:52 -0400 From: Yunlong Song To: , , , , CC: , , , , Subject: [PATCH v2] f2fs: update dirty status for CURSEG as well Date: Fri, 13 Oct 2017 21:21:37 +0800 Message-ID: <1507900897-156286-1-git-send-email-yunlong.song@huawei.com> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1507728318-113117-1-git-send-email-yunlong.song@huawei.com> References: <1507728318-113117-1-git-send-email-yunlong.song@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.193.250] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090206.59E0BF17.00C4,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 6d34363e0e49d5e1af29b18dd9bb2859 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Without this patch, it will cause all the free segments using up in some corner case. For example, there are 100 segments, and 20 of them are reserved for ovp. If 79 segments are full of data, segment 80 becomes CURSEG segment, write 512 blocks and then delete 511 blocks. Since it is CURSEG segment, the __locate_dirty_segment will not update its dirty status. Then the dirty_segments(sbi) is 0, f2fs_gc will fail to get_victim, and f2fs_balance_fs will fail to trigger gc action. After f2fs_balance_fs returns, f2fs can continue to write data to segment 81. Again, segment 81 becomes CURSEG segment, write 512 blocks and delete 511 blocks, the dirty_segments(sbi) is 0 and f2fs_gc fail again. This can finally use up all the free segments and cause panic. Signed-off-by: Yunlong Song --- fs/f2fs/segment.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index bfbcff8..0fce076 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -687,7 +687,7 @@ static void __locate_dirty_segment(struct f2fs_sb_info *sbi, unsigned int segno, struct dirty_seglist_info *dirty_i = DIRTY_I(sbi); /* need not be added */ - if (IS_CURSEG(sbi, segno)) + if (IS_CURSEG(sbi, segno) && dirty_type == PRE) return; if (!test_and_set_bit(segno, dirty_i->dirty_segmap[dirty_type])) @@ -737,7 +737,7 @@ static void locate_dirty_segment(struct f2fs_sb_info *sbi, unsigned int segno) struct dirty_seglist_info *dirty_i = DIRTY_I(sbi); unsigned short valid_blocks; - if (segno == NULL_SEGNO || IS_CURSEG(sbi, segno)) + if (segno == NULL_SEGNO) return; mutex_lock(&dirty_i->seglist_lock); -- 1.8.5.2