From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758176AbdJMOuU (ORCPT ); Fri, 13 Oct 2017 10:50:20 -0400 Received: from mail-by2nam01on0052.outbound.protection.outlook.com ([104.47.34.52]:7144 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753494AbdJMOuS (ORCPT ); Fri, 13 Oct 2017 10:50:18 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; From: Madalin Bucur To: , CC: , , , , Subject: [PATCH v2 0/5] adapt DPAA drivers for DSA Date: Fri, 13 Oct 2017 17:50:07 +0300 Message-ID: <1507906212-10076-1-git-send-email-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.1.0 Reply-To: X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523798158027051;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39380400002)(346002)(39860400002)(376002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(305945005)(356003)(316002)(68736007)(16586007)(5003940100001)(39060400002)(47776003)(54906003)(3450700001)(48376002)(104016004)(85426001)(6666003)(2906002)(110136005)(86362001)(50466002)(8936002)(50226002)(33646002)(4326008)(50986999)(53936002)(36756003)(5660300001)(43066003)(8676002)(77096006)(97736004)(106466001)(81156014)(81166006)(105606002)(498600001)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR03MB2702;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD007;1:7jvpe39QUFzQ1NivvYdWW257eBhwyFgxNZKK/oo7/jkdH/xlHdpD/f2SSjcVGchaylwfNs/juj5nzNV98pTBmWnhKFefgw8JqR1dXYc7EqttCSBTcQ7SA4nozaud1PiK MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9995af89-85fd-48b9-292b-08d51249b72f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017052603199)(201703131430075)(201703131517081);SRVR:MWHPR03MB2702; X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2702;3:NALJTVcMCzSp7+igHgu14kCXyAVwsPVJLKdDZ3ODsiyr/m2vs71FGGvfD9d45vGT/3j35QG6ETYw8MO3+zb4jaC+Zhzf14w3lAra0Vzpu8lvSnCxH0ovVqjYlqw9/k5nkgfr4Lwky/J+o1TOZMjlztF/rHqN9G4UYNZiENWs20CbOZwCz0PRWR9FF2Nz9wn2qlMuS7bj8E7W9hRHbMrSgdipbasTtNlSADBBrGggYrrP2YqnpTX7bbHp98DLf+3bPGjvX2wfjIaQSAHF7ySLaAv0dRCM66zrAD2St8FnHEi6ppg+6vpC4TysMoZaNhRQt9IqrtXFBOPk/PQth5GCcwh/s4YhWae66lOvYJuW3NA=;25:NW2vUAmJ/XHiP1jqCtYhUB0P9C82EJOe/tE+oN262i/6oOi2ww0/+35mVs8SdTwwXtQgoAgMmo56wKXGFOqI7mOJFjThUo3Cvshm4BaaowJhnZgW+Yz0GWksdyBhbG3SrPYeC3P9SoQ/FZ5tvkoQ6C9YTxGF63E6csn9Ghwo6VflPJeZjDu5gArC2CAS7gXfWRxue7WMS7FOYesS3YpmMFssNPXImQMGpRpSdPqqaeA8d+TByazX5tYtm3WWKbgHHTLHQ9nAAv2tX0QFMDle5j6Bu+KIdKMHcQb73uDW4ksMxg97TMZRgA57RCvNMoQHuvrHVKgRhUU7dbCbm9WnjA== X-MS-TrafficTypeDiagnostic: MWHPR03MB2702: X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2702;31:jFu6rzQgrSJe8HCr9xBy97njTbXC/CriSlOAU2YdZ1h/aGM0mBhz1fWvpQPS9fGlH/831rQlvJafJ1XF6B4N++xb2zV4FOZtWPlQXAHZIFk1QM7CfNQUyTalKlmCajM2ryRgSVEk9zpbHEvyKyv+3/AEyUMzbysOBlI8oXRyG0fm/u4adh7DX03oP91bSOp2m0p9gzL+HF2tlzv4yc+gqo9sZBrj24D48zsrHRFk18k=;4:yrecn3XJRHs7E3PQQjdrTau1jpfOj43x8oNpeC1KxPHm5EkC6q5RuvfbUiE+KTdJlCTknzlaWhCXr9cM/dcmhTV841okFUfph7Z2GiPZM1Kzgbfrm0NEQWaMAlpR6x1Nubkx7RymAaj6KSGmqF07n0fRH8SxN6tfKywy1GMXr4LgF+W3eAHvVYVEvYlJ5cD3JzESJDEPCuQIX53C2Ic+CqKhvykchN+Uv7VbUV0h7UQPAGHPnl/8b1U2LXu8+x4X X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6096035)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123565025)(20161123561025)(20161123559100)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR03MB2702;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR03MB2702; X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR03MB2702;23:6rwZTKmteoc0nRvViUQWYPXE7mDnL7xKrP9QcnzJh?= =?us-ascii?Q?o8zuadIzg/MXC+D+98o0AL4aIcuetomzCHopU97mx5ivYZXaTjU7Z+deLHr9?= =?us-ascii?Q?fkKPS87Ie8Z/rqcgdueuO37wm3Diq7G/X69e6CGvdP1aPR5RhUv504ImqMd7?= =?us-ascii?Q?u5tQWIZbHrzYnFo2iMoJJPoSD4R9UWVsMXQ7xSmIuz3l2rvR5mGm/2g4YebS?= =?us-ascii?Q?18/65GfusoB4Mky6sjhfxX8fuO3giq5vThnHRI/nm6PJVkoas9JhfMelJGiq?= =?us-ascii?Q?Umx4jvE5eAg0WM/n5r+GSl/LJ9IqOUfE734D3k/IaGGMRxJMup0YtatYPHRl?= =?us-ascii?Q?Q9+ix0eTFOls2dz1uAOn6VuNLiWPoWj28k9e3ug9yKwAcdmJcHywDzC2w6rh?= =?us-ascii?Q?4E87klnCPNGjqKM8iA4rqlIVJn5x77OHnDr6k6d4gZiRqkFIe8Eso+ARaH84?= =?us-ascii?Q?npEwf7Jjk+CvDCqeySFdLEIGo9FALb+YX/6Qlex0Etjhv0XsICrkl8QVraYC?= =?us-ascii?Q?1EUBKSS6xLyyxIlKTt83FTB376w5IN7HLTEyiWv+g3UQRD5VB+nTtvKeS+Yv?= =?us-ascii?Q?dBXqYPH9chBrxBNpGiiWYJYRL49xAjleN2BdC4+fkzx66X0PiYGHZ88TE58O?= =?us-ascii?Q?FXcI55mAgezhcyw/76vcTbSRurnObwcLYAc+NcHI47qj4rsDQxhHML0rKYNl?= =?us-ascii?Q?uY+gO0fv14YwfKH5UKZDBpuJaDTYJqkuPtFlARFniKKVuEZUiYhBzMAVfPAg?= =?us-ascii?Q?xZvSDaEfMvV6bzeYOzbOsvfis6/hRyfRB8t1NLMNUMyHhgUkdOEybiiYlw9A?= =?us-ascii?Q?4D0GLN7QOp/q5Ul1msdNEQCEYuYEzFEolJdp19HgRWcjXJ6KFsKWSYi13DKJ?= =?us-ascii?Q?q6AZVNM6IBzYusFoS+i/NcFBgi9PktrZjspSD4ydOTHizjwDY83mhLqVeoh8?= =?us-ascii?Q?0eMQY+lceVQbuX0svTx7ztJoztyLO0RXEFVb/nF6MOeEG68VhCCFRXFzNqW4?= =?us-ascii?Q?kxjXGsxzmzm3mBDpOaDLMtUmFVuFDMf7cB9F3M5hcW0iWHAiXKOkY8/ucU0I?= =?us-ascii?Q?hBB2cB7ThG1FRM6ieI78iTsUS1lwYCN/1+pbCxprOJV8gTvgjTR3O2PEeTDg?= =?us-ascii?Q?ex/9zk6LO2Virt8myHKrqYpm4U+WuzbUXeag3XdJX/XScBY7tT/zQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2702;6:ejnze5fuFLEPU59Fq71OMAzipQljJgHE6nFcXpUQV12fRYgKLBgsBBFcHzyZe1g2WKL+9Fm08nsuofJB6eqKzkes7gDjCnHEDS6JYZHmmPsPC+waEsIdOWwniYbMGAutzKVdnVk5zZLoGq17LLpSimJBMExBBSbX+dF7KK/gtyvEnqu76iPaayc/aEK2WqiizbHxTEqXNLXp/9727k6bmQ8sh+EXzcbiKE8b1KNeCkngMAmjHbNEfwhgUofMs7nnjACAq/GPXhR8e830RC30kEH1VUPl2kMiqSuF+0ALuP1xqFOq7jPRXuREAYp73ZLc7QuYKRtYlFPqvarDkBCdlg==;5:mQzPjiWr3CnZMKzyhJmzjBnXBr7zlv6P7LnDo6c71t7nnJx4Vqiqxcl/hd+VIcQ3VnQEMO1R1GoUrZe/9Hdz3NFME+IMHySD+2VSN4ERgvVcjoCHTcgw8J6g9aPs8fmjVllNAAQ5+A0zyMBToXevEg==;24:KeoUSCuy9BKF9eyh7HAgIYSO2y3Fv1k8vUcIbXRKTTGyX0nWWj3pMBtGwidxpDpLrHs5gVjUXgMXF5GAadF7hMaqb2qcDMzRSAKg+N+66eU=;7:RM0mGz22rk8+5om0ttWkXrwGkVnnmWcxzu6TKRVJDvEx/0v+jaJAgjJODXD8/DmPvM/XzMjkSykD4Qy+DqCnbTTI2WTjxNw36ro2jL4ChIKaxy1O5ap+OcTKiuq7h/MyQ+T5HbstoreO5xyFp+ShPLMm3W+zu6qjpi43pgsbBFziX5qjgxMK7+jD3Sew7d/x15/PFFLyJhSK+6sXGNAKPcvl7cHMlToRyyiigiC1KDc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 14:50:15.6155 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2702 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Junote Cai reported that he was not able to get a DSA setup involving the DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node() call in DSA setup. The initial attempt to fix this by adding of_node to the platform device results in a second, failed, probing of the FMan MAC driver against the new platform device created for the DPAA Ethernet driver. Solve these issues by removing the of_node pointer from the platform device and changing the net_dev dev to the of_device dev to ensure the DSA init will be able to find the DPAA net_dev using of_find_net_device_by_node(). Several changes were required to enable this solution: refactoring the adjust_link (also resulted in lesser, cleaner code) and renaming the fman kernel modules to keep the legacy udev rules happy. Changes in v2: - fix issue on error path in "dpaa_eth: change device used" patch - cleanup the dpaa_eth_probe() error paths Madalin Bucur (5): fsl/fman: remove of_node dpaa_eth: move of_phy_connect() to the eth driver dpaa_eth: change device used dpaa_eth: cleanup dpaa_eth_probe() error paths fsl/fman: add dpaa in module names drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 143 +++++++++++++------------ drivers/net/ethernet/freescale/fman/Makefile | 12 +-- drivers/net/ethernet/freescale/fman/mac.c | 135 ++++++----------------- drivers/net/ethernet/freescale/fman/mac.h | 6 +- 4 files changed, 119 insertions(+), 177 deletions(-) -- 2.1.0