From: Paul Mackerras <paulus@samba.org>
To: William Ie <wie@CS.Stanford.EDU>
Cc: linux-kernel@vger.kernel.org, mc@CS.Stanford.EDU
Subject: Re: [CHECKER] security rules?
Date: Fri, 27 Apr 2001 14:20:26 +1000 (EST) [thread overview]
Message-ID: <15080.62346.34932.272251@argo.ozlabs.ibm.com.au> (raw)
In-Reply-To: <Pine.GSO.4.21.0104261426520.18211-100000@Xenon.Stanford.EDU>
In-Reply-To: <200104130947.CAA21780@csl.Stanford.EDU> <Pine.GSO.4.21.0104261426520.18211-100000@Xenon.Stanford.EDU>
William Ie writes:
> 4.linux/2.4.3/drivers/net/ppp_async.c:345:ppp_async_ioctl
> case PPPIOCGFLAGS:
> val = ap->flags | ap->rbits;
> if (put_user(val, (int *) arg))
> break;
> err = 0;
> break;
> case PPPIOCSFLAGS:
> if (get_user(val, (int *) arg))
> break;
> ap->flags = val & ~SC_RCV_BITS;
> spin_lock_bh(&ap->recv_lock);
> ap->rbits = val & SC_RCV_BITS;
> spin_unlock_bh(&ap->recv_lock);
> err = 0;
> break;
> seems to be getting and setting some flags without CAP_NET_ADMIN like in
> ppp_synctty.c
It is OK because this is a channel ioctl routine called from
ppp_generic.c as a result of an ioctl call on /dev/ppp, and it is not
possible to open /dev/ppp unless you have CAP_NET_ADMIN.
Paul.
prev parent reply other threads:[~2001-04-27 4:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-13 9:47 Dawson Engler
2001-04-13 12:07 ` Chris Evans
2001-04-26 21:51 ` William Ie
2001-04-27 4:20 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15080.62346.34932.272251@argo.ozlabs.ibm.com.au \
--to=paulus@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@CS.Stanford.EDU \
--cc=wie@CS.Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®