From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751716AbdJPCJi (ORCPT ); Sun, 15 Oct 2017 22:09:38 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:32925 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbdJPCJg (ORCPT ); Sun, 15 Oct 2017 22:09:36 -0400 X-ME-Sender: Message-Id: <1508119775.3619640.1139764440.2F1A81C9@webmail.messagingengine.com> From: Tobin Harding To: "Roberts, William C" , Linus Torvalds Cc: kernel-hardening@lists.openwall.com, KVM list , Linux Kernel Mailing List , Kees Cook , Paolo Bonzini , Tycho Andersen , Tejun Heo , Jordan Glover , Greg KH , Petr Mladek , Joe Perches , Ian Campbell , Sergey Senozhatsky , Catalin Marinas , Will Deacon , Steven Rostedt , Chris Fries , Dave Weinstein , Daniel Micay , Djalal Harouni MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-26fdae60 References: <1507676974-1298-1-git-send-email-me@tobin.cc> <476DC76E7D1DF2438D32BFADF679FC563F4AF591@ORSMSX115.amr.corp.intel.com> Date: Mon, 16 Oct 2017 13:09:35 +1100 Subject: Re: [PATCH 0/3] add %pX specifier In-Reply-To: <476DC76E7D1DF2438D32BFADF679FC563F4AF591@ORSMSX115.amr.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 14, 2017, at 04:54, Roberts, William C wrote: > > > > -----Original Message----- > > From: linus971@gmail.com [mailto:linus971@gmail.com] On Behalf Of Linus > > Torvalds > > Sent: Tuesday, October 10, 2017 4:17 PM > > To: Tobin C. Harding > > Cc: kernel-hardening@lists.openwall.com; KVM list ; > > Linux Kernel Mailing List ; Kees Cook > > ; Paolo Bonzini ; Tycho > > Andersen ; Roberts, William C > > ; Tejun Heo ; Jordan Glover > > ; Greg KH ; > > Petr Mladek ; Joe Perches ; Ian > > Campbell ; Sergey Senozhatsky > > ; Catalin Marinas ; > > Will Deacon ; Steven Rostedt ; > > Chris Fries ; Dave Weinstein ; Daniel > > Micay ; Djalal Harouni > > Subject: Re: [PATCH 0/3] add %pX specifier > > > > On Tue, Oct 10, 2017 at 4:09 PM, Tobin C. Harding wrote: > > > > > > This patch is a softer version of Linus' suggestion because it does > > > not change the behaviour of the %p specifier. I don't see the benefit > > > in making such a breaking change without addressing the issue of %x (and I > > don't the balls to right now). > > > > The thing is, this continues to have the exact same issue that %pK has > > - because it is opt-in, effectively nobody will actually use it. > > > > That's why I would suggest that if we do this way, we really change %p and %pa > > to use the hashed value, to convert *everybody*. And then people who have a > > good reason to actually expose the pointer have to do the extra work and opt > > out. > > Yes we cannot make this opt in or there is really no point in doing it. > %pK and mistakes > got us here to this point. I see there is multiple threads, this getting > really fun to follow. The threading split is my fault. I have never worked on a patch series with this many comments. How could I have gone about things differently to prevent the thread separation? Should I have posted the second patch set as a reply to the first (I did not because it was not a version 2). Further splitting occurred because I botched the `git send-email` and sent only a cover-letter, this got some replies that lead to another single patch (again it was quite different and seemed not to be a version 2)? So we are left with three threads all discussing the same changes. Is there anything one can do to rectify this position now? thanks, Tobin.