From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754222AbdJPQGj (ORCPT ); Mon, 16 Oct 2017 12:06:39 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:19357 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbdJPQGf (ORCPT ); Mon, 16 Oct 2017 12:06:35 -0400 X-IronPort-AV: E=Sophos;i="5.43,387,1503331200"; d="scan'208";a="58215165" From: Bart Van Assche To: "hare@suse.de" , "ming.lei@redhat.com" CC: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "himanshu.madhani@cavium.com" , "tom81094@gmail.com" , "paolo.valente@linaro.org" , "axboe@kernel.dk" , "linux-scsi@vger.kernel.org" , "oleksandr@natalenko.name" , "john.garry@huawei.com" , "osandov@fb.com" , "loberman@redhat.com" , "james.smart@broadcom.com" Subject: Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops Thread-Topic: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops Thread-Index: AQHTQ4lc2pZDXOhe5U6IuYSs5ux9RaLgjbsAgABdCgCAAPGtgIAAF0GAgAAGiACAAAQCAIAABo2AgAAF6ICABFJ5gIAATTiA Date: Mon, 16 Oct 2017 16:06:32 +0000 Message-ID: <1508169991.2493.17.camel@wdc.com> References: <20171012183704.22326-1-ming.lei@redhat.com> <20171012183704.22326-5-ming.lei@redhat.com> <9a741c03-90a3-e583-ddde-0ed71c8570a2@kernel.dk> <20171013001919.GA24715@ming.t460p> <6efdb459-8746-562d-06dc-5b3e172076e1@kernel.dk> <20171013160731.GA30899@ming.t460p> <1507912260.13345.0.camel@wdc.com> <20171013164519.GF30899@ming.t460p> <1507914527.13345.17.camel@wdc.com> <20171013172950.GA32319@ming.t460p> <515ca83f-5629-31e2-ef70-1869ae1b75ef@suse.de> In-Reply-To: <515ca83f-5629-31e2-ef70-1869ae1b75ef@suse.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1535;20:0PJ1tazNv1TG9hx5E5tsXcLCwL+1Vn3BVnNo9h65Zpgi4zasDIM8wwTwnuImY1j8WxYeHOkyebJmTYIK0+txQEnoSYO3sdnnQkgVdmJWddAe3IcSche82bEI7crl+cYzX/nrlMHpG6dPRpk7cAVonlI8e1ePO0wrB7o/ReOQJHk= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 8af9b457-cd81-4eb2-8ef4-08d514afde43 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1535; x-ms-traffictypediagnostic: CY1PR0401MB1535: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1535;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1535; x-forefront-prvs: 0462918D61 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(39860400002)(346002)(377424004)(189002)(24454002)(199003)(53936002)(2501003)(8676002)(72206003)(99286003)(7416002)(81166006)(6512007)(2906002)(305945005)(101416001)(2900100001)(4001150100001)(14454004)(93886005)(33646002)(54906003)(86362001)(110136005)(316002)(189998001)(81156014)(36756003)(25786009)(6246003)(3846002)(6486002)(229853002)(5660300001)(6116002)(102836003)(66066001)(77096006)(478600001)(8936002)(105586002)(3280700002)(106356001)(68736007)(2950100002)(50986999)(4326008)(3660700001)(39060400002)(6436002)(97736004)(7736002)(54356999)(6506006)(103116003)(76176999)(142923001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1535;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <54DC10A5C1C5F54EAAC0C863820E1187@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2017 16:06:32.1719 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1535 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9GG6iTE029081 On Mon, 2017-10-16 at 13:30 +0200, Hannes Reinecke wrote: > On Fri, Oct 13, 2017 at 05:08:52PM +0000, Bart Van Assche wrote: > > (+Himanshu Madhani) > > > > Himanshu, do you perhaps know whether it is safe to increase cmd_per_lun for > > the qla2xxx initiator driver to the scsi_host->can_queue value? > > '3' is just a starting point; later on it'll be adjusted via scsi_change_depth(). > Looks like it's not working correctly with blk-mq, though. Hello Hannes, Isn't the purpose of scsi_change_queue_depth() to change the sdev queue_depth only? As far as I know there is only one assignment of shost->cmd_per_lun in the SCSI core and that's the following assignment in scsi_host_alloc(): shost->cmd_per_lun = sht->cmd_per_lun; Bart.