From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756719AbdJPSgS (ORCPT ); Mon, 16 Oct 2017 14:36:18 -0400 Received: from mail-bn3nam01on0086.outbound.protection.outlook.com ([104.47.33.86]:31920 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756474AbdJPSgQ (ORCPT ); Mon, 16 Oct 2017 14:36:16 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; From: Madalin Bucur To: , CC: , , , , Subject: [PATCH v3 0/6] adapt DPAA drivers for DSA Date: Mon, 16 Oct 2017 21:36:04 +0300 Message-ID: <1508178970-28945-1-git-send-email-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.1.0 Reply-To: X-EOPAttributedMessage: 0 X-Matching-Connectors: 131526525743101491;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39860400002)(376002)(346002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(316002)(81166006)(8936002)(86362001)(77096006)(5003940100001)(36756003)(47776003)(8676002)(356003)(6666003)(2906002)(50986999)(305945005)(33646002)(104016004)(68736007)(105606002)(81156014)(69596002)(50226002)(43066003)(106466001)(85426001)(54906003)(110136005)(39060400002)(53936002)(189998001)(50466002)(3450700001)(5660300001)(97736004)(16586007)(4326008)(48376002)(498600001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR03MB2692;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD009;1:+BhKLN/RaZZYqsm5+aq5hKXv9Fy4ppNuMzIGBLr/CfslIVR7EKG7BMXlV554O1quwbIaRMNilQRcdzUJYTRxVHmxTGyTvhoRxNWSqhQas4nEWph+/8cN3pwxvLjU3gP1 MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa5f045b-682f-49bb-14d3-08d514c4c7ea X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017052603199)(201703131430075)(201703131517081);SRVR:BN6PR03MB2692; X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2692;3:UCAwHW5w2S16Je1xyjYt9rGRlv5dGxGaXwyq2ltiMqcF/j/u71v18IzJMnJXXuj6jdIWvCG2MxTPUQENWnf996l/BtOakmewd5kT2gCroRJpZoUxYndhjyJUUbogy0NqiiKcRrpA0FMT1Quontnhxk2BEGh3cvEzpfDeGNvqb1e0oIpd/eraFgiXPaiYyeuID9QaeY7K1qXs5vSPtDinOadlsM+bJCRcksbwe0RVD7WeB4qc9WQq1H7HQQoPxGDo1jjriq1NKG0EBDeG1UKEHivlSETrasQAg+QOIWlLLiTJVWBKWlLI8bsHjz0q7Bh2MdwqsUfBo4Dz/zhSu8OSPK+QWvEVcFdexDWyTrLnLFM=;25:A7+/Yno0yuycwbowYf5gzcg7WD1wfIBe5f+b7KLlPWObWx3YaRPtSjTMoNXHEsMBpWtIU/5gyEnTau18bBT9xgIXxF2VtimiEB546QOmfkEEsUAVlgB/UNOacTAuIRhe0DFaIyewuPs8C/eXpgGcMZ0SLYAJMDwdXNU3yqz/4X9vlEV+AXUOdtlu10mhafIa7xAjabuJDO7f8BO01B395CXjwCBJRo58KOgThyzYO/9KZJVu8JT80XzeOpB+gELP/X8b1cjLSdWx5Y6l2ndJ5bmrqxOtWg3oqSX/eWVRwjqShoUqREoQBKGwELW+bdf5nbp7IL3JuaaMY8FC47pnNw== X-MS-TrafficTypeDiagnostic: BN6PR03MB2692: X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2692;31:CEREj51ctJC+ZGDjtfxhKJ3HVPtmaEKsTZwigJ2pI0cl2dPboQA7Zh40YZrDX3DmwG9D57Wt8n8BRW/d1r22segzfTJp8Bb6WdQaGi9aY9J0oR9R+mTERvTn70TsGyy+Ac0f6EcyzjpWvJFZY5LMu6XXHonMNS7IJoz3+2txLHhG0L4/btvkL14p4560xGdwtTF1MJuPImN6cN5wbCNPuknLyIGaGbpQvuxWFjatOzQ=;4:Z2b0tbW9vhlEsKCRLlUgrClUrZAmWnlPBU6Y9YWaLIWlzyQ5nBAgITiUyzBuM5dQFzViyfodfVPASNl4dl15jNVNa+2dqOYmgQC1A4L3mggw59NaRuQ0SbsWjaiyX4YpksQVAakPvCd0AC3RszLR7NpNRW3t2GkEKenynNX9rLoeFWnpTgULp4lF/xq3m5DKSXd6g878s5pNjbboG6gtKyXe3zNJXktDSGdDo5JeI60xO0RnsxBdYBZS4D+dcXTE X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6096035)(20161123556025)(20161123563025)(20161123565025)(20161123559100)(20161123561025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR03MB2692;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR03MB2692; X-Forefront-PRVS: 0462918D61 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR03MB2692;23:ikaUGq6fC/8GrEKcHOsP4jqVlHEZ08dQ3oPj7PCV8?= =?us-ascii?Q?yCRau/gK6S96D+4cgZ55n2kIM8cy4URon/9sZbWf0VuMMh76+opx8berPfrm?= =?us-ascii?Q?AuJZciMWUmlwYM9T/ZeKfsygubDl8eDtNco7EHuNRnKp/odHHOfrelSRGFUt?= =?us-ascii?Q?BYSUnpjJPDDrFA6TdoEXV60tF9hy5a50zqDgViear3bsC4cXMNMAChPFsvni?= =?us-ascii?Q?CodfFiR3GUcq+mjoF1TrNF7mBYpeM/06Jgi6SJqg9l+BwPx2SRbmH1xwT3hd?= =?us-ascii?Q?awPiNkHFzkqO9oV+VRC3JMIfFJymN8gKHhB3FtEHvPXtti6ytIAM1uswoF+h?= =?us-ascii?Q?OQPDyOLr/M5J+sRYAeCa63i/57lfTa+Nhrw+9apzIW8OQfHJH9BlgCVTrtGb?= =?us-ascii?Q?lgyOdRjNkMHi2weny1BWQ+xsDAVmZ/83AxbGt86q0Ruh2jf6MBIF4WB8d8nS?= =?us-ascii?Q?wnfEqPsSvZOzuT/x4gd8gKkrZjxuF30m7wJ1A0OX7aWyObFeWTzfYh3h1VWQ?= =?us-ascii?Q?reSNYodjyl+jHdgifY3NOrzA2IovxECfy8tJWgSBFUTEqKrAYupw7w1XAvXz?= =?us-ascii?Q?7AgvxTvyye9MUxHrez77/V4LVkhrwPsIQ+844s9qWyD8ypZ9xJnS2aj3uwQd?= =?us-ascii?Q?2CO26vcmB829gdG8WCLr90pn25ybosD+r4rm12NkJcTQ88NLGWsNwXV8A/hK?= =?us-ascii?Q?d1QPyTElFo3ZRDKrUJ1+sE4tZ4WVB0QbS8ajIFq1+ZjdLjOwD9CPQxddLa3v?= =?us-ascii?Q?qj9Mz7krynvUdY4M1tH7LrKKC/sTdlikm2OPPlyxbusCS5kDtd8cEOb5RKSd?= =?us-ascii?Q?8fkow+JPl+rU1CtcynAsgT5zGU76TjO5KXqjECJMO4Sc4cAHsEiSk4IiB863?= =?us-ascii?Q?7Q7Af4SvUqwqNtMHcGK2ua3Oyw669hBnF/Y0V0Cw3JWjPw8LhLuZlbUXh26l?= =?us-ascii?Q?O8fPZglF7fEObK1fHqVWhS9xkHsBN/5xAwyc+KgbXBMWJdklFGISsUzbU5fb?= =?us-ascii?Q?vXaPNxN34Mso6BdHK5z6yMKTxLrljEyxGkh48kp828VdrKJKAjtBo4HogA00?= =?us-ascii?Q?US8m+kkwjikD6y4CABFY4skhbutXKebyGcuOL7n0v577LaGtjHkdsXFK4AoN?= =?us-ascii?Q?vhSv9F/FCGyHqX/UT2Cv4FhBLWSKONB2BF11sJnl/sLs19aVcM1INhRxgsWy?= =?us-ascii?Q?aVAm+IZhbjeeW8=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2692;6:/WBX2bvUPZeGIoYyEQ5u5WGdNA4CBr3IynUVY4cgAxYBzC+ct8GYCeS3VLG5ibkEzg6MRsUJrk7XXpVsAl0nq5dOWUAeFVepg75wH9vhJek08/KvOo/Bqrg2dcrDlAIh44k3u0hzSY66vJr2h2YAtepU2RPHp2P700FTI/ZrOahbDM1k2QLPUYtBug4iXDyssDYmO6hyJSldOVSc8vPfmC/AUIHaSmgpQyOziKVZ3ppUs2hDSEb2ZK++zoFBitYfiFv7baQM0kPCkuX5e5wzGz8hfoApKpk5sHq4OVfS5CgGj57W8NZgoGKEdVMTN6aoGdt8YFKH05pefKKxXvXDhw==;5:8JtrhMTPOS9X177jT8srUBWk4WX6u1jQU/2XFVBuhDismTPT7BlZlMBloeTLMcHNDf7bt9Oe1zm+247ENhP94Ww0r5cvGwtElBsjT/+ctfCo1gPUggozAsoJv78ELjZ9AxGJwKlr4mF+ioHsAf5zxgU17/kcEPOa3mTcXMIW0FA=;24:dgrzVR2teZTFC86PNI+dEqPGpTdaCMfIFAoYNZYBB/OJAvIXYf74GXPEs5bZfhMhRb1BRo2cKenpK2Xp950HePxrXxgoD0BimqfmwuGrs28=;7:OWhlshbcijJCikXJy8STH2LFNKUb089rnfko0f9xyfC5T1egfnZq2vxgSXLkINfiZMGCPe6/LC6X95dwU6rqePgpCvhYhxvuKXrIWJLYTf6GkQGRdCsyCNLFuJkL659UFcdiKKs7SpfAK6P2O4JNfzIftw+nia5SWtHfWVDKVQhzblen5jPyyR9qa0eAL6Ug2QULjdcilhdTtU9x7hP5x2nxJ/QmtuRqdIML2R1vuoc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 18:36:14.0605 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2692 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Junote Cai reported that he was not able to get a DSA setup involving the DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node() call in DSA setup. The initial attempt to fix this by adding of_node to the platform device results in a second, failed, probing of the FMan MAC driver against the new platform device created for the DPAA Ethernet driver. Solve these issues by removing the of_node pointer from the platform device and changing the net_dev dev to the of_device dev to ensure the DSA init will be able to find the DPAA net_dev using of_find_net_device_by_node(). Several changes were required to enable this solution: refactoring the adjust_link (also resulted in lesser, cleaner code) and renaming the fman kernel modules to keep the legacy udev rules happy. Changes in v2: - fix issue on error path in "dpaa_eth: change device used" patch - cleanup the dpaa_eth_probe() error paths Changes in v3: - remove obsolete comment in moved code - add explanation for module rename Madalin Bucur (6): fsl/fman: remove of_node dpaa_eth: move of_phy_connect() to the eth driver dpaa_eth: change device used dpaa_eth: cleanup dpaa_eth_probe() error paths fsl/fman: add dpaa in module names dpaa_eth: remove obsolete comment drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 139 +++++++++++++------------ drivers/net/ethernet/freescale/fman/Makefile | 12 +-- drivers/net/ethernet/freescale/fman/mac.c | 135 +++++++----------------- drivers/net/ethernet/freescale/fman/mac.h | 6 +- 4 files changed, 115 insertions(+), 177 deletions(-) -- 2.1.0