From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758359AbdJQEV1 (ORCPT ); Tue, 17 Oct 2017 00:21:27 -0400 Received: from mail-db5eur01on0131.outbound.protection.outlook.com ([104.47.2.131]:14148 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756848AbdJQEVX (ORCPT ); Tue, 17 Oct 2017 00:21:23 -0400 Authentication-Results: spf=pass (sender IP is 131.228.2.240) smtp.mailfrom=nokia-sbell.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=pass action=none header.from=nokia-sbell.com; X-HPESVCS-Source-Ip: 10.159.218.88 From: Lixin Wang To: Rob Herring , Frank Rowand CC: , , Lixin Wang Subject: [PATCH v2] of: dynamic: fix memory leak related to properties of __of_node_dup Date: Tue, 17 Oct 2017 12:20:19 +0800 Message-ID: <1508214019-61974-1-git-send-email-alan.1.wang@nokia-sbell.com> X-Mailer: git-send-email 2.6.2 In-Reply-To: <1507858967-40416-1-git-send-email-alan.1.wang@nokia-sbell.com> References: <1507858967-40416-1-git-send-email-alan.1.wang@nokia-sbell.com> X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:131.228.2.240;IPV:CAL;SCL:-1;CTRY:FI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(376002)(346002)(2980300002)(438002)(199003)(189002)(189998001)(26826003)(478600001)(356003)(8676002)(81156014)(2906002)(46386002)(50226002)(45336002)(8936002)(86362001)(103686004)(39060400002)(81166006)(4326008)(52956003)(97736004)(47776003)(76176999)(106002)(50986999)(110136005)(107886003)(54906003)(48376002)(50466002)(2950100002)(5660300001)(305945005)(5003940100001)(6666003)(90966002)(36756003)(22756006)(16586007)(6266002)(316002)(33646002)(42186006)(68736007)(106466001)(53936002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR07MB1288;H:mailrelay.int.nokia.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:3;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;VE1EUR03FT018;1:7EmLoyfIAmTfIFj7l3BOtVsY/B/iK/2/+XuLGvgOJkuiaU2vp4rl6tPuEeVcSEw7xIwkVJbXfNvD6nT2Ur2BUxC02V1ygtEYTSmsplVBRk1bLJMpQHX+y07X1SsVyEgy MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 03c79d6a-bf99-455e-4f4b-08d5151682c2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DB5PR07MB1288; X-Microsoft-Exchange-Diagnostics: 1;DB5PR07MB1288;3:/gtEy+VyHVxIrLCy7b8QnCj8za4nRb7xn2kPsOMV1bHIhs0oIKwpsLiD32VfGRBy8WQY9+wRWpv0YZ70klztEKmg3wJWT3abOIanpSrN7VesO0448e8+AgyZwdBJgciVaCbznDXnoHzLl93VVEfDkLViiW+aTRkBUHPty/IKc+8oWHrEJKWRa9w1rwyyYqsAPbABQYAFFn17EbLxlSbXZbg7Yr7Fev/SHM6NhbPQhLBbr9dyt++6YndOkhSA9sG4vVacplWXfypF9zINzfd2rUF7Z06Gduan+xQaCVOzqmqJT0MryUXHI9nucYgIBVlz4YETNujhTWPbwsBK9rmBAzvS8Row6eSgFVHTM5aUkl8=;25:UxdwDJCcj+PA7FVWkTAHGlb1DlOFYAo0OGlrFLtZM75ai1xgYJz028Lis+UcjNgQfZq9r1zsnRh4oZv0kQVOna2uyoUp7PL56qpQwyokGhSFYfqFtVKsx/AqDL3+4D6OKw12Q5wh642jInlhqq5ONxBwoARZcBS06foZEkwxr+dObWWkd3x2OgYmDNhoqlgVmNmb6qCyo4MEk6Mbr5rP87CjLUdWC1bRdnxnEoLzhP6EWd4JHlLL5R384kBG7l5fEXuwIl34wXKORrIzXX+ZePKbLdQYwzzI2wzfiH18o5xmIv0FRiEwh754A+d1vXmPKueVg0oY14PmNQAjT8yDYA== X-MS-TrafficTypeDiagnostic: DB5PR07MB1288: X-Microsoft-Exchange-Diagnostics: 1;DB5PR07MB1288;31:1CXUpainc5CIGCwwd0c5dHnt4xSJmZG9l+fYnLqbDHlYLPJSmnomFIHsVfIint8crBzpxtVF3RWIB0jY5bLu27pg9EWaFmBFa4EWRWxlaVfqTbpec4M0psKE/MXh0Z7Xb4mhhQ+WzJ4AJecFKHnmIYXplgTMQVlWlJusn5dcUCYG9lv2vvxmJT5Vfhr/echnZoXYt1Gjz7zGa9eOhtCzy2VoFlfu2QJYYa27eRA1VVw=;20:W8R3UpRdA0SGgzc++CJClxQ5AfwKQQXnalHq2FlOom4Z37jxj6VlPvR+PmXXb3xhNOAdhEauhCYFbg4f40YEIHatpuHHm3+R7wBrU1dr7ge2FbfEdr38TX8ZnCIWh0yDQJ75iV8PSRDEBAz1Y0sJdLnXS2V0Q1spXGk0ofLUgCyaBNLit962AQmmPMcmBBR4LusCjHdyzgArsz/rWBBBu2UFdF1bGGslvSd/fwxzQCUCTL2ksnFQZKlFLizeZUjSEM4GFH35DcuLUCQGJKMxAFwnwBHIoKnlM4qs9NIVGNH6fSflSPQlsdYj8DgUb609q2xfKQBMNgnx1xvifdKsz2+eCa7pnbbtj5Wl9vaT4UDP2w+9DOZNbA8ZibcIwCjEMAjpMGCNDjf3YumY6kEKa4i0/njy+MaSi03JdzZmj99KKUR5bkvIRr1KxGrCBEyfCgODJh4a/wZ28BHv4KH5T5aJkkrI46dhc/ihCKDIADe4/EMeAxN8UiGsaeZceTZY83L25ZJ9GCglLpLJ/Q8in/7l2Csiazzk8Mkyirzt2eoiNubZoKZ9rjzhzN3DHwIJtQvyCkTNudZabYcl2IRRGZwp/AEjBXd/hXmbLuyqP2E= X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93004095)(10201501046)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB5PR07MB1288;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB5PR07MB1288; X-Microsoft-Exchange-Diagnostics: 1;DB5PR07MB1288;4:kL+ngpfZP1qQexa2zqlL02xDQxW55Xgl9wHmWlLVgC7EppJLjPQ93OLi3lf7D+osqZiuNUFCip0DE9TGUjNBp5e6gsz+czSjREVSXuwrwt/8bqQEYaY9QS2Icp44GbEyXwCahpd06n94zBKLKI+weylJPhHfIlF6DbIQlP2YfRhgj0GTIOP81qy/cOs0/Yr+dLcZ8NIhgLmRkFWhNKEoiK6n4ry412B/qmr7WkjmJ3oqD1f2gaaVnmnagCyDW2sC X-Forefront-PRVS: 04631F8F77 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB5PR07MB1288;23:Zl6/3kglzkL9LRLP4jCjXGPmZeEiCNArlHCb/UMsX?= =?us-ascii?Q?W3qpiGugqqPtJ5jzarGGxgVy9NgdP/rrc0yAP7eafS6+IsbpNdJ2PCengQ7D?= =?us-ascii?Q?SQtHVw+W4UxW8okqWNszge3x103l2eRK/3EeIAfR4c5PWmNVgx8YfYvZi3ta?= =?us-ascii?Q?sGP74tm5lxiVCRyZDfqxphsfZWGdLI4e+sga6559+FBLI2idYu/bgvDndXcv?= =?us-ascii?Q?OfKU5yx2jWo/hUGCBKYb6j2/p6hXWoEzP0gdWkln4g4P4TmYyF2muG0/hSxb?= =?us-ascii?Q?IouEZ2wU/Rk1uWdpjpHKs7Iw8hFbSgNKr8MUAezCYafa/evpbefvaI5aNH1U?= =?us-ascii?Q?KLZNRZDu/CPO4Jwoz0aglCN3gDdQzemYbJoqUL9JDn1yrkldQgJbVXG+e8o1?= =?us-ascii?Q?h0hjkJ2ka0Hg//rH4noy2U4iNuQXN0T+RMXr4JeblbYPP+yIRNn/4B13Pj2b?= =?us-ascii?Q?l1EU2u1QsT/b/aA9WplGgoKK2II665SEuMGMSiJ+uyC706eO69b/zuoWeJqX?= =?us-ascii?Q?U9OhjISQ/hvUC14OsxEduMn6EPg/IZV29awcMPi8ZweFOaG3Vc6embSCbGDX?= =?us-ascii?Q?Ne/OdJHSkwVMhm3hV5o6jUg6A4Uu2a8HQ19HwTZmulFLK4uQS5n6YHvdGN8X?= =?us-ascii?Q?0CMixn5HOkwY9reHruxSN7NxTV7vfMbk/dICJaTx7qiqE0+149nzqz451Lyq?= =?us-ascii?Q?+ioCDkwtLz5psIz+FBsDtQhPqALfu3577HBITM6gFrVmO2nGTRHVQnYlRqeX?= =?us-ascii?Q?QiQjhDNhW/VjrujdczV+G+AD+D1qHnnw061TksylM6q1kk9wjF8obnDaYu9f?= =?us-ascii?Q?PMOqROeXlxYX1vAVhUsWV8JUO5FNT5udsC5R95LlYi/wiGTzdKghK4v3D1/W?= =?us-ascii?Q?hdOwnKToamO/lG/s0VOzGE/OvM1QBibCJC4xbGnfDYM5Rg4/ujBn2ZjrP6Ck?= =?us-ascii?Q?dBRB+CnfxoxN0bWRctwb8L+6xf7ZvL1TNEPkANx0hU+wddqbSMlPMNdsI9hz?= =?us-ascii?Q?XVo/9GRPt5b5qfdcNmit3LyWkXDWRau7z7CghSuWBxK/tzC0DgdS9PHt0GxP?= =?us-ascii?Q?kP5nWGukSHFFIw9uTZWGeTec8Mkj9Zl540J2rxfOONuGzhE7C6Sf+zSICT8L?= =?us-ascii?Q?kYJOc1v8qzM1O2kNCZmmtBXczRQZxTuw+pJZDozGRteb2VncVbO/HJu8Annh?= =?us-ascii?Q?JFiQiDo7LpxnCZt2ewhptseyOlG+CZcJuVS?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR07MB1288;6:Js5Oc4MvS71g6fzUjFezkCTWu1m7yJpNE3dZBrEOnWHa8lOG+S6Afzs4btLv7n7CoYDUxHiLXiL8js6hqLOjUhV5QLutE9Zb6fGBNAE2wya2Hnn6sJeARiSRgnmV7c7cuzKDguTzHWrLVw/U/Rhr96nffIaADNfDIDB411Txuifkd3sXx/iXZakuMvoxhjyXGQD0oaaJ9uQZFKG8EvJ9UI84pHMh0IWvKykpqUzJtYK2pCHpnBF/ciMd174hz4MMFz/s3nqU3uQY9UwszGpwBhQ94m2se8E0c0Y4gNWMQ+yQ+GWaZwNo1rvIKz9sZETh4l0dA7cnQIGqHjk38CMv2w==;5:wowkI2QANekPonVZR4/JT5t5gZCTo0JsvxUd24QgezydXFQqxyf0InoqkqAk8Sg/gxGmerhGWy0bdza4ZUlYU1XLXmjyW+eCYpNTzRtiHqXjtXFDD7g+Vsbo0msw7VK2nnThwbsX8TeoWaJBsHN7Jcd5Tb3c7jvrYEPBOmgyGXI=;24:d3S9p86y+Lu/QvZtLsFjQN+DcOnZr4LqX9GzleFe3mYRGm9XLueFw8akwbXSyz1cxM9WcptjtUS6Mv50bGwap8ZiLMV+YfrkZ4l94GRjheI=;7:vjWt2gKptfM07JRpG12NOMgeUmcNN+ZXsP9auE0BXJLYNvWA+HbWeNwhIMVwMzywZnbTEH8ellCFIrX9hWPiDs/whwfvxpuR6Yv2awgLfZ/V92d3t/FaaZ/YO7fzvoS0mw6PCtuxNEaH4inPjWGdlu1RJUxaKtaJVJFjrveD5QUsvY9rpxv+/SgNKN0uGZj5mhinxbxSZs3dwe3arWiwfM3oYY/CxWwbfPCu+8NrTAM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nokia-sbell.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2017 04:21:16.8154 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 03c79d6a-bf99-455e-4f4b-08d5151682c2 X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5d471751-9675-428d-917b-70f44f9630b0;Ip=[131.228.2.240];Helo=[mailrelay.int.nokia.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR07MB1288 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a node with no properties is dynamically added, then a property is dynamically added to the node, then the property is dynamically removed, the result will be node->properties == NULL and node->deadprops != NULL. Signed-off-by: Lixin Wang --- v1: * Change the description of this patch as suggested by Frank Rowand. drivers/of/dynamic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c index 301b6db..465d43b 100644 --- a/drivers/of/dynamic.c +++ b/drivers/of/dynamic.c @@ -335,6 +335,10 @@ void of_node_release(struct kobject *kobj) if (!of_node_check_flag(node, OF_DYNAMIC)) return; + if (!prop) { + prop = node->deadprops; + node->deadprops = NULL; + } while (prop) { struct property *next = prop->next; kfree(prop->name); -- 2.6.2