From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761298AbdJQKwY (ORCPT ); Tue, 17 Oct 2017 06:52:24 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:41615 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755876AbdJQKwX (ORCPT ); Tue, 17 Oct 2017 06:52:23 -0400 Message-ID: <1508237537.6854.8.camel@pengutronix.de> Subject: Re: [PATCH 3/4] reset: tegra: check BPMP response return code From: Philipp Zabel To: Thierry Reding Cc: Timo Alho , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 17 Oct 2017 12:52:17 +0200 In-Reply-To: <20171017104043.GB30589@ulmo> References: <00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com> <20171017104043.GB30589@ulmo> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thierry, On Tue, 2017-10-17 at 12:40 +0200, Thierry Reding wrote: > On Thu, Sep 07, 2017 at 12:31:03PM +0300, Timo Alho wrote: > > Add checks for return code in BPMP response message. > > > > Signed-off-by: Timo Alho > > --- > > drivers/reset/tegra/reset-bpmp.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > Hi Philipp, > > Would you provide an Acked-by on this so that I can take it into the > Tegra tree? There's a build dependency on patch 1/4 in the series. Acked-by: Philipp Zabel to take this via the Tegra tree. > Quoting in full since you were not previously on Cc, unfortunately. > > Timo, please remember to always Cc the relevant maintainers. > > Thierry > > > diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c > > index 5daf2ee..fac2db6 100644 > > --- a/drivers/reset/tegra/reset-bpmp.c > > +++ b/drivers/reset/tegra/reset-bpmp.c > > @@ -23,6 +23,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc, > > struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc); > > struct mrq_reset_request request; > > struct tegra_bpmp_message msg; > > + int err; > > > > memset(&request, 0, sizeof(request)); > > request.cmd = command; > > @@ -33,7 +34,13 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc, > > msg.tx.data = &request; > > msg.tx.size = sizeof(request); > > > > - return tegra_bpmp_transfer(bpmp, &msg); > > + err = tegra_bpmp_transfer(bpmp, &msg); > > + if (err < 0) > > + return err; > > + else if (msg.rx.ret < 0) > > + return -EINVAL; I don't really understand why you complicate the call sites like this instead of just letting tegra_bmp_transfer return -EINVAL if msg.rx.ret < 0, but I haven't seen the other patches. regards Philipp