From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933432AbdJRCB2 (ORCPT ); Tue, 17 Oct 2017 22:01:28 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:51164 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933393AbdJRCBX (ORCPT ); Tue, 17 Oct 2017 22:01:23 -0400 X-Google-Smtp-Source: AOwi7QBtxeRz05pEAF7+dlWQFkB12KSK+Tw8pN4fG52VvkiodXiKKJen35zINasJZW8TBY3vDnAlYA== From: Kees Cook To: Jessica Yu Cc: Kees Cook , linux-kernel@vger.kernel.org Subject: [PATCH 0/3] module: Do not paper over type mismatches in module_param_call() Date: Tue, 17 Oct 2017 19:01:08 -0700 Message-Id: <1508292071-139844-1-git-send-email-keescook@chromium.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The module_param_call() macro was explicitly casting the .set and .get function prototypes away with (void *). This can lead to hard-to-find type mismatches. Additionally, it creates problems for static checkers and Control Flow Itegrity compiler features, which depend on clustering function call sites based on prototype signature. This removes the casts and fixes all the incorrect prototypes tree-wide. -Kees