From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679AbdJSJxI (ORCPT ); Thu, 19 Oct 2017 05:53:08 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:47608 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752649AbdJSJxD (ORCPT ); Thu, 19 Oct 2017 05:53:03 -0400 X-Google-Smtp-Source: ABhQp+QanVTOVgAvnZBZHqAf/kns0BlLKHYqBYReem2eXTf6hnG+9T907gepnCiNCi2USTAYiLYVuw== From: Raveendra Padasalagi To: MyungJoo Ham , Chanwoo Choi , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: bcm-kernel-feedback-list@broadcom.com, Raveendra Padasalagi Subject: [PATCH v3 2/2] extcon: add optional input-debounce attribute Date: Thu, 19 Oct 2017 15:22:53 +0530 Message-Id: <1508406773-887-2-git-send-email-raveendra.padasalagi@broadcom.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1508406773-887-1-git-send-email-raveendra.padasalagi@broadcom.com> References: <1508406773-887-1-git-send-email-raveendra.padasalagi@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add changes to capture optional dt attribute "input-debounce" provided in extcon node and used the same value if provided otherwise default value of 20000 usecs is used for id and vbus gpios debounce time. Signed-off-by: Raveendra Padasalagi Reviewed-by: Ray Jui Reviewed-by: Srinath Mannam --- Changes in v3: - Changed USB_GPIO_DEBOUNCE_MS to USB_GPIO_DEBOUNCE_USEC - Changed msecs_to_jiffies() to usecs_to_jiffies() Changes in v2: Rename gpio_debounce_timeout_ms to debounce_usecs drivers/extcon/extcon-usb-gpio.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c index 9c925b0..69149e2 100644 --- a/drivers/extcon/extcon-usb-gpio.c +++ b/drivers/extcon/extcon-usb-gpio.c @@ -28,7 +28,7 @@ #include #include -#define USB_GPIO_DEBOUNCE_MS 20 /* ms */ +#define USB_GPIO_DEBOUNCE_USEC 20000 /* us */ struct usb_extcon_info { struct device *dev; @@ -41,6 +41,7 @@ struct usb_extcon_info { unsigned long debounce_jiffies; struct delayed_work wq_detcable; + unsigned int debounce_usecs; }; static const unsigned int usb_extcon_cable[] = { @@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev) if (IS_ERR(info->vbus_gpiod)) return PTR_ERR(info->vbus_gpiod); + ret = of_property_read_u32(np, "input-debounce", + &info->debounce_usecs); + if (ret) + info->debounce_usecs = USB_GPIO_DEBOUNCE_USEC; + info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable); if (IS_ERR(info->edev)) { dev_err(dev, "failed to allocate extcon device\n"); @@ -147,13 +153,13 @@ static int usb_extcon_probe(struct platform_device *pdev) if (info->id_gpiod) ret = gpiod_set_debounce(info->id_gpiod, - USB_GPIO_DEBOUNCE_MS * 1000); + info->debounce_usecs); if (!ret && info->vbus_gpiod) ret = gpiod_set_debounce(info->vbus_gpiod, - USB_GPIO_DEBOUNCE_MS * 1000); + info->debounce_usecs); if (ret < 0) - info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS); + info->debounce_jiffies = usecs_to_jiffies(info->debounce_usecs); INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable); -- 1.9.1