From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753746AbdJSVD2 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Oct 2017 17:03:28 -0400
Received: from lb1-smtp-cloud8.xs4all.net ([194.109.24.21]:37196 "EHLO
        lb1-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753117AbdJSVD0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Oct 2017 17:03:26 -0400
Message-ID: <1508447002.2274.14.camel@tiscali.nl>
Subject: Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()
From: Paul Bolle <pebolle@tiscali.nl>
To: Kees Cook <keescook@chromium.org>,
        "David S. Miller" <davem@davemloft.net>
Cc: Karsten Keil <isdn@linux-pingi.de>, Johan Hovold <johan@kernel.org>,
        gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Date: Thu, 19 Oct 2017 23:03:22 +0200
In-Reply-To: <1508200182-104605-33-git-send-email-keescook@chromium.org>
References: <1508200182-104605-1-git-send-email-keescook@chromium.org>
         <1508200182-104605-33-git-send-email-keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-CMAE-Envelope: MS4wfIjBX3JJOEBE08ndlnli09V2uGUktcGyXB0uf11/kdDOVru1PW956/nS854rscvt3r5++gXU56ertC2TwZ5dE8vh/gYXxChs8wjLtPbAojxIb+tFa/gu
 I3FH2FPp84gGQ74iGpBbkjz7NNaMkLYt8TPL6cfsci70tGJK21sikkbhAc/i7Wkx1H7gD/5g/j+/wotJvGYyrDljKbM3ZLKYiOZMendY1iZSJfgNx6M8Tl/a
 DDetGVNXtK3bLSFL3NRIqU7BCTOLV59m6WipQUlrrGZxcxHwx2JBOqNQ2qc1bVYE+/NRKTqiT+tjVVxfE9q5JSvSpjnhA9YlbrL3iV0leqEbjB+y4bjUP1HS
 zc4pCgJzyvIVG2RdFNiJMQSDMlX99PRvquQkgqUQ1QAGfQ9HMes4wi6yVuWwCmRW9Z2yfwEzZdZUT1AmlftHC8ncOs6ZAjbMSjRmkHEy6DxaO03CVy0=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.

Acked-by: Paul Bolle <pebolle@tiscali.nl>

For the record: this patch made me nervous but survived the rigorous testing I
threw at it. (Ie, dialing up using bas_gigaset and downloading almost 20 MB in
just over an hour. Whoot! That's more than good enough to ack this patch.)

There was some cleanup I had in mind to make this patch more straightforward.
But that can wait until someone finds a way to hit an issue with this patch.
We'll see.

Thanks,


Paul Bolle