From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893AbdJSVSl (ORCPT ); Thu, 19 Oct 2017 17:18:41 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:54217 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbdJSVSi (ORCPT ); Thu, 19 Oct 2017 17:18:38 -0400 X-Google-Smtp-Source: ABhQp+TkI2KWiHJs1BtwL6g9pai3M6vBXfFpyBbM5Qxx61wIG3/m22B6mKFQ8ZJ5qinKoD+nSLZzsA== From: frowand.list@gmail.com To: Rob Herring , atull@kernel.org, pantelis.antoniou@konsulko.com, Pantelis Antoniou Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove Date: Thu, 19 Oct 2017 14:18:27 -0700 Message-Id: <1508447907-4462-1-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP, or an embedded errno. overlay_notify() incorrectly reports an error for NOTIFY_OK. Reported-by: atull@kernel.org Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index c99842bb4b09..f5fce0fea40b 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs, ret = blocking_notifier_call_chain(&overlay_notify_chain, action, &nd); - if (ret == NOTIFY_STOP) + if (ret == NOTIFY_OK || ret == NOTIFY_STOP) return 0; if (ret) { ret = notifier_to_errno(ret); -- Frank Rowand