From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751544AbdJSXbu (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Oct 2017 19:31:50 -0400
Received: from lb1-smtp-cloud7.xs4all.net ([194.109.24.24]:55662 "EHLO
        lb1-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751426AbdJSXbs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Oct 2017 19:31:48 -0400
Message-ID: <1508455899.2274.73.camel@tiscali.nl>
Subject: Re: [PATCH 32/58] isdn/gigaset: Convert timers to use timer_setup()
From: Paul Bolle <pebolle@tiscali.nl>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        "David S. Miller" <davem@davemloft.net>,
        Karsten Keil <isdn@linux-pingi.de>, Johan Hovold <johan@kernel.org>,
        gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 20 Oct 2017 01:31:39 +0200
In-Reply-To: <alpine.DEB.2.20.1710200025470.2054@nanos>
References: <1508200182-104605-1-git-send-email-keescook@chromium.org>
                  <1508200182-104605-33-git-send-email-keescook@chromium.org>
                  <1508447002.2274.14.camel@tiscali.nl>
          <1508448028.2274.21.camel@tiscali.nl>
          <alpine.DEB.2.20.1710192328110.2054@nanos>
         <1508449907.2274.28.camel@tiscali.nl>
         <alpine.DEB.2.20.1710200025470.2054@nanos>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-CMAE-Envelope: MS4wfIbK8Q9g3M1h7IgVH/kqT9MhnCqO55pPR8+a+CL1BjL8gbtm8VrAP8fgatVLZMLJcevz0QSpzGpsatzJyCpiJ9lrB0+A0rIy+WaEFz/8CzyF9NatN5CJ
 8oYG+WsbPchY1mENktNjvqvyNbtUPSCAwH0j5wl5Sy1eTvaObyuB7ku7lhGcRr2cTxjYOao/YYMd6uELn0wv7z+zgOFkHNsWosxsCdyOLR+6gggt6+vdIMLa
 PAH7m/Lc+eve3Gey49Px62KsOwWNWblaYQt0+kYpZvvlBtT7SmT3NfZAUPt6FlwYmoEvJiqyCEt2yHjBuVY8cItimwtz4zPa8ESMEV6jdrz5zauNue0DYO/Y
 AIDq0AOqXSMET4ELer/X+ItLUDudC8eN85A8MVH0DrVqHxnJrDWhCCNU8zqbW6LLy8dqMkukr3SMX1oU6VRjlNmsLQAA/6GriqhU4Q83/Q/nU5btgsfYcukN
 38qt5tUWsILPr7pjeZAFcAiZMvrflgoRtB7N+g==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[CC-ing Linus because I quote him.]

On Fri, 2017-10-20 at 00:28 +0200, Thomas Gleixner wrote:
> Well, that does not explain why
> 
>       drivers->cs + i
> 
> would be corrupted. That would require that this cs -> urb link points at
> driver magically and then wreckages that driver data structure. Might be
> the case, but if so then there are dragons burried somehwere

Let's assume dragons are buried somewhere.

We need users to show us that they met a dragon, right? (I care little about
dragons no-one ever stumbles upon.)

In the explanation of commit 9f5af546e6ac ("isdn/i4l: fix buffer overflow")
Linus added:
    [ ISDN seems to be effectively unmaintained, and the I4L driver in
      particular is long deprecated, but in case somebody uses this..
        - Linus ]

ISDN is pretty niche. So it's no surprise that in mainline it's divided into
three parts: I4L, CAPI, and mISDN.

Arnd Bergmann has suggested more than once to move I4L to staging. (As far as
I know, moving drivers to staging effectively means removing those drivers,
but anyhow.) I'd say we'd just should do that. The stuff has been deemed
deprecated since basically forever.

I never cared about mISDN, but as far as I can see mISDN has quietly left
mainline.

The only actively maintained CAPI drivers are gigaset's drivers. But I'm
afraid maintaining gigaset basically means seeing treewide cleanups fly by and
  keeping the various fuzzers happy. I don't mind, and I could keep on doing
that for years. But still, I'd love to hear someone say: yes, I still care
about mainline ISDN.

Does that person still exists?

Thanks,


Paul Bolle