From: Jerome Brunet <jbrunet@baylibre.com>
To: marc.zyngier@arm.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
hkallweit1@gmail.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:irq/core] irqchip/meson: Disable COMPILE_TEST
Date: Fri, 20 Oct 2017 11:28:30 +0200 [thread overview]
Message-ID: <1508491710.3616.38.camel@baylibre.com> (raw)
In-Reply-To: <tip-d9ee91c1b1fe56b905b767f4a0063d3624e1a1cf@git.kernel.org>
On Fri, 2017-10-20 at 02:21 -0700, tip-bot for Thomas Gleixner wrote:
> Commit-ID: d9ee91c1b1fe56b905b767f4a0063d3624e1a1cf
> Gitweb: https://git.kernel.org/tip/d9ee91c1b1fe56b905b767f4a0063d3624e1a1c
> f
> Author: Thomas Gleixner <tglx@linutronix.de>
> AuthorDate: Fri, 20 Oct 2017 11:15:36 +0200
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Fri, 20 Oct 2017 11:17:17 +0200
>
> irqchip/meson: Disable COMPILE_TEST
>
> The driver fails to compile with CONFIG_COMPILE_TEST=y on x86:
>
> irq-meson-gpio.c: In function ‘meson_gpio_irq_parse_dt’:
> irq-meson-gpio.c:343:8: error: implicit declaration of function
> ‘of_property_read_variable_u32_array’
> ret = of_property_read_variable_u32_array(node,
>
> Adding COMPILE_TEST to a driver requires at least compile testing it for
> x86....
Indeed, sorry about that.
Thanks for fixing.
>
> Reported-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> ---
> drivers/irqchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 1cb3940..85d0fb2 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -326,7 +326,7 @@ config IRQ_UNIPHIER_AIDET
>
> config MESON_IRQ_GPIO
> bool "Meson GPIO Interrupt Multiplexer"
> - depends on ARCH_MESON || COMPILE_TEST
> + depends on ARCH_MESON
> select IRQ_DOMAIN
> select IRQ_DOMAIN_HIERARCHY
> help
parent reply other threads:[~2017-10-20 9:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <tip-d9ee91c1b1fe56b905b767f4a0063d3624e1a1cf@git.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508491710.3616.38.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=hkallweit1@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome