From: kan.liang@intel.com
To: acme@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, jolsa@kernel.org, wangnan0@huawei.com,
hekuang@huawei.com, namhyung@kernel.org,
alexander.shishkin@linux.intel.com, adrian.hunter@intel.com,
ak@linux.intel.com, Kan Liang <Kan.liang@intel.com>
Subject: [PATCH V3 4/6] perf tools: add perf_data_file__open_tmp
Date: Fri, 20 Oct 2017 13:05:32 -0700 [thread overview]
Message-ID: <1508529934-369393-5-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1508529934-369393-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <Kan.liang@intel.com>
And an interface for perf_data_file to open tmp file.
Automatically generate the tmp file name if it's not assigned. The name
cannot be const char. Introduce char *tmp_path for it.
The tmp file will be deleted after close.
It will be used as per-thread file to temporarily store event synthesizd
result in the following patch.
Signed-off-by: Kan Liang <Kan.liang@intel.com>
---
tools/perf/util/data.c | 26 ++++++++++++++++++++++++++
tools/perf/util/data.h | 2 ++
2 files changed, 28 insertions(+)
diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
index 1123b30..cd6fdf9 100644
--- a/tools/perf/util/data.c
+++ b/tools/perf/util/data.c
@@ -139,9 +139,35 @@ int perf_data_file__open(struct perf_data_file *file)
return open_file(file);
}
+int perf_data_file__open_tmp(struct perf_data_file *file)
+{
+ int fd;
+
+ if (!file->tmp_path &&
+ (asprintf(&file->tmp_path, "perf.tmp.XXXXXX") < 0))
+ goto err;
+
+ fd = mkstemp(file->tmp_path);
+ if (fd < 0) {
+ free(file->tmp_path);
+ goto err;
+ }
+
+ file->fd = fd;
+ return 0;
+err:
+ file->tmp_path = NULL;
+ return -1;
+}
+
void perf_data_file__close(struct perf_data_file *file)
{
close(file->fd);
+ if (file->tmp_path) {
+ unlink(file->tmp_path);
+ free(file->tmp_path);
+ file->tmp_path = NULL;
+ }
}
ssize_t perf_data_file__write(struct perf_data_file *file,
diff --git a/tools/perf/util/data.h b/tools/perf/util/data.h
index ae510ce..892b3d5 100644
--- a/tools/perf/util/data.h
+++ b/tools/perf/util/data.h
@@ -10,6 +10,7 @@ enum perf_data_mode {
struct perf_data_file {
const char *path;
+ char *tmp_path;
int fd;
bool is_pipe;
bool force;
@@ -43,6 +44,7 @@ static inline unsigned long perf_data_file__size(struct perf_data_file *file)
}
int perf_data_file__open(struct perf_data_file *file);
+int perf_data_file__open_tmp(struct perf_data_file *file);
void perf_data_file__close(struct perf_data_file *file);
ssize_t perf_data_file__write(struct perf_data_file *file,
void *buf, size_t size);
--
2.7.4
next prev parent reply other threads:[~2017-10-20 20:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 20:05 [PATCH V3 0/6] event synthesization multithreading for perf record kan.liang
2017-10-20 20:05 ` [PATCH V3 1/6] perf tools: pass thread info to process function kan.liang
2017-10-20 20:05 ` [PATCH V3 2/6] perf tools: pass thread info in event synthesization kan.liang
2017-10-20 20:05 ` [PATCH V3 3/6] perf tools: expose copyfile_offset() kan.liang
2017-10-20 20:05 ` kan.liang [this message]
2017-10-23 16:13 ` [PATCH V3 4/6] perf tools: add perf_data_file__open_tmp Jiri Olsa
2017-10-23 16:19 ` Liang, Kan
2017-10-23 16:26 ` Jiri Olsa
2017-10-23 18:05 ` Liang, Kan
2017-10-24 7:26 ` Jiri Olsa
2017-10-24 7:26 ` Jiri Olsa
2017-10-20 20:05 ` [PATCH V3 5/6] perf record: synthesize event multithreading support kan.liang
2017-10-20 20:05 ` [PATCH V3 6/6] perf record: add option to set the number of thread for event synthesize kan.liang
2017-10-23 11:48 ` [PATCH V3 0/6] event synthesization multithreading for perf record Ingo Molnar
2017-10-23 13:43 ` Liang, Kan
2017-10-23 14:25 ` acme
2017-10-23 18:45 ` Liang, Kan
2017-10-24 9:22 ` Ingo Molnar
2017-10-24 11:47 ` Jiri Olsa
2017-10-24 12:47 ` Liang, Kan
2017-10-24 12:59 ` Ingo Molnar
2017-10-24 13:08 ` Arnaldo Carvalho de Melo
2017-10-24 13:25 ` Ingo Molnar
2017-10-25 2:35 ` Namhyung Kim
2017-10-25 9:02 ` Jiri Olsa
2017-10-25 9:00 ` Jiri Olsa
2017-10-25 9:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508529934-369393-5-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®