mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: kbuild-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: kbuild 2.5 problems with netfilter linking
Date: Sat, 06 Apr 2002 14:48:02 +1000	[thread overview]
Message-ID: <15086.1018068482@ocs3.intra.ocs.com.au> (raw)

AKA - Rusty shoots himself in the foot :)

kbuild 2.5 defines

 -DKBUILD_OBJECT=module, the name of the module the object is linked
    into, without the trailing '.o' and without any paths.  If the
    object is a free standing module or is linked into vmlinux then the
    "module" name is the object itself.  Automatically generated.

This variable is aimed at standardizing boot and module parameters, so
'insmod foo option=value' and booting with 'foo.option=value' will have
exactly the same effect.  Rusty already has code to do this and is
waiting for kbuild 2.5 to go in.

Alas netfilter has objects that are linked into multiple modules,
$(ip_nf_compat-objs) is linked into both ipfwadm and ipchains so
KBUILD_OBJECT is ambiguous.  Two possible solutions -

* Change netfilter so the objects are not linked twice.  That will
  require $(ip_nf_compat-objs) to be a module in its own right with
  extra exported symbols.

* Change kbuild 2.5 to detect multi linked objects and not set
  KBUILD_OBJECT for those objects.  It follows that multi linked
  objects cannot have module or boot parameters, so change modules.h to
  barf on MODULE_PARM() and __setup() when KBUILD_OBJECT is not
  defined.

I am tending towards the second solution.


             reply	other threads:[~2002-04-06  4:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-06  4:48 Keith Owens [this message]
2002-04-07  7:36 ` Rusty Russell
2002-04-09 12:02   ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15086.1018068482@ocs3.intra.ocs.com.au \
    --to=kaos@ocs.com.au \
    --cc=kbuild-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®