From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751132AbdJVEXU (ORCPT ); Sun, 22 Oct 2017 00:23:20 -0400 Received: from mailgw02.mediatek.com ([218.249.47.111]:58134 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750797AbdJVEXT (ORCPT ); Sun, 22 Oct 2017 00:23:19 -0400 X-UUID: 6bde0d05563d4529b289ad5a3a339112-20171022 Message-ID: <1508646191.29850.23.camel@mtkswgap22> Subject: Re: [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error From: Sean Wang To: Matthias Brugger CC: , , , , , , , Date: Sun, 22 Oct 2017 12:23:11 +0800 In-Reply-To: <20171021082529.31351-2-matthias.bgg@gmail.com> References: <20171021082529.31351-1-matthias.bgg@gmail.com> <20171021082529.31351-2-matthias.bgg@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote: > When adding the MT6380 compatible, the sentinel for of_device_id was > deleted, which leades to the following compiler error: > FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry! > > Fix this by adding the sentinel again. > > Signed-off-by: Matthias Brugger > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 912edf93c192..e9e054a15b7d 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = { > }, { > .compatible = "mediatek,mt6397", > .data = &pmic_mt6397, > + }, { > /* sentinel */ > } > }; Thanks for patching the mistaken edit I made. Acked-by: Sean Wang