From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932344AbdJWBcd (ORCPT ); Sun, 22 Oct 2017 21:32:33 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:60686 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932177AbdJWBcZ (ORCPT ); Sun, 22 Oct 2017 21:32:25 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20171023013223epoutp02b29b1ec21a6161412d2b536b516fa226~wDvpf4NgK1222412224epoutp02b X-AuditID: b6c32a37-f0bff70000001049-f1-59ed469f6c56 From: Chanwoo Choi To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com Cc: rafael.j.wysocki@intel.com, chanwoo@kernel.org, inki.dae@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 4/7] PM / devfreq: Change return type of devfreq_set_freq_table() Date: Mon, 23 Oct 2017 10:32:09 +0900 Message-id: <1508722332-10628-5-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1508722332-10628-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsWy7bCmvu58t7eRBkfeillMvHGFxeL6l+es FpPuT2CxONv0ht3i8q45bBafe48wWtxuXMFm8XjFW3YHDo/Fe14yeWxa1cnm0bdlFaPH501y ASxRqTYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QGco KZQl5pQChQISi4uV9O1sivJLS1IVMvKLS2yVog0NjfQMDcz1jIyM9EyMY62MTIFKElIzdr3b yl5wU6hiaUtqA+Mi/i5GTg4JAROJHb2TWboYuTiEBHYwSnz438sO4XxnlDizvpsFpmrfgp+s EIkNjBLdO6cyQzg/GCU2PT/EBlLFJqAlsf/FDTBbRCBAonPtKiaQImaBJkaJ/fdusIMkhAXC JO7v6GMEsVkEVCWut34Fi/MKuEosmNMMtU5O4sOeR2BxTgE3ibtrvzKCDJIQ6GCTWHhuCytE kYvE0qUbGCFsYYlXx7cANXAA2dISl47aQtS3M0psnnOPBaqZUeL+ykaoZmOJU12NTCA2swCf xLuvPawQzbwSHW1CECUeEsen74aa7yhxdsknMFtIYCajxOq7ZhMYpRYwMqxiFEstKM5NTy02 LDDWK07MLS7NS9dLzs/dxAhOJlrmOxg3nPM5xCjAwajEw8tg+DZSiDWxrLgy9xCjBAezkgjv HAugEG9KYmVValF+fFFpTmrxIUZTYNhMZJYSTc4HJrq8knhDE0sDEzMjYGKwNDRUEucVW38t QkggPbEkNTs1tSC1CKaPiYNTqoHRZmnbuujHjPkC1ys9Wsuc7897t3Gd9MU8vcxTkU7Gi/Mv MlTHnAkTqb666e6FlPn/Hprs8zGVO3a5Uk8iI+PSE0+jhqW/Q4pzts1dvdb9SFf4qzMlrZy7 Zr+7uTSAPf7ZPpdnTD9XLJ666/Tf/laGm8VZvjsK3+lLXinctE/qnO8ijzQZvfvMSizFGYmG WsxFxYkAaVLt0DwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphluLIzCtJLcpLzFFi42I5/e+xoO58t7eRBnfWMFlMvHGFxeL6l+es FpPuT2CxONv0ht3i8q45bBafe48wWtxuXMFm8XjFW3YHDo/Fe14yeWxa1cnm0bdlFaPH501y ASxRXDYpqTmZZalF+nYJXBm73m1lL7gpVLG0JbWBcRF/FyMnh4SAicS+BT9Zuxi5OIQE1jFK 7Nq8jxnC+cEo0XeknQ2kik1AS2L/ixtgtoiAn8T2+esZQYqYBZoYJZb33wJLCAuESdzf0ccI YrMIqEpcb/3KDmLzCrhKLJjTzAKxTk7iw55HYHFOATeJu2u/gtULAdX8/fSfaQIjzwJGhlWM kqkFxbnpucVGBYZ5qeV6xYm5xaV56XrJ+bmbGIFhtO2wVt8OxvtL4g8xCnAwKvHwMhi+jRRi TSwrrsw9xCjBwawkwjvHAijEm5JYWZValB9fVJqTWnyIUZqDRUmc93besUghgfTEktTs1NSC 1CKYLBMHp1QDo1ORk737rKVhc51L/Z9mbC38NVH9WnnznO7yGxGL2s0TEvs7Jlz8ml1bXrM/ O8UxaIUJh+NO9Ryv9piJNZFVX1d5PtokwCdi9Kd9/u6UVb5H/3UqrN0U77raXn9Z4ssmgZWf GaROHDVfrZ9pM7v/zKRDcarP1q28XRBzf5L4Lr6yzSeeHJ7yXomlOCPRUIu5qDgRAEMTRu8f AgAA X-CMS-MailID: 20171023013215epcas1p3e43fa1b26d20fcb7d7d5d89fd28f9166 X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171023013215epcas1p3e43fa1b26d20fcb7d7d5d89fd28f9166 X-RootMTR: 20171023013215epcas1p3e43fa1b26d20fcb7d7d5d89fd28f9166 References: <1508722332-10628-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch changes the return type of devfreq_set_freq_table() from 'void' to 'int' in order to check whether it fails or not. And This patch just removes the 'devfreq' prefix and the description of function. Because the helper functions are only used by the devfreq. Signed-off-by: Chanwoo Choi Acked-by: MyungJoo Ham --- drivers/devfreq/devfreq.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index ee3e7cee30b6..b2920cd2b78e 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -116,11 +116,7 @@ static int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq) return -EINVAL; } -/** - * devfreq_set_freq_table() - Initialize freq_table for the frequency - * @devfreq: the devfreq instance - */ -static void devfreq_set_freq_table(struct devfreq *devfreq) +static int set_freq_table(struct devfreq *devfreq) { struct devfreq_dev_profile *profile = devfreq->profile; struct dev_pm_opp *opp; @@ -130,7 +126,7 @@ static void devfreq_set_freq_table(struct devfreq *devfreq) /* Initialize the freq_table from OPP table */ count = dev_pm_opp_get_opp_count(devfreq->dev.parent); if (count <= 0) - return; + return -EINVAL; profile->max_state = count; profile->freq_table = devm_kcalloc(devfreq->dev.parent, @@ -139,7 +135,7 @@ static void devfreq_set_freq_table(struct devfreq *devfreq) GFP_KERNEL); if (!profile->freq_table) { profile->max_state = 0; - return; + return -ENOMEM; } for (i = 0, freq = 0; i < profile->max_state; i++, freq++) { @@ -147,11 +143,13 @@ static void devfreq_set_freq_table(struct devfreq *devfreq) if (IS_ERR(opp)) { devm_kfree(devfreq->dev.parent, profile->freq_table); profile->max_state = 0; - return; + return PTR_ERR(opp); } dev_pm_opp_put(opp); profile->freq_table[i] = freq; } + + return 0; } /** @@ -601,7 +599,9 @@ struct devfreq *devfreq_add_device(struct device *dev, if (!devfreq->profile->max_state && !devfreq->profile->freq_table) { mutex_unlock(&devfreq->lock); - devfreq_set_freq_table(devfreq); + err = set_freq_table(devfreq); + if (err < 0) + goto err_out; mutex_lock(&devfreq->lock); } -- 1.9.1