From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751152AbdJWFB4 (ORCPT ); Mon, 23 Oct 2017 01:01:56 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60616 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbdJWFBz (ORCPT ); Mon, 23 Oct 2017 01:01:55 -0400 From: Kamalesh Babulal To: Josh Poimboeuf Cc: Kamalesh Babulal , linux-kernel@vger.kernel.org, Ingo Molnar Subject: [PATCH] objtool: Refactor insn search in add_dead_ends() Date: Mon, 23 Oct 2017 10:31:08 +0530 X-Mailer: git-send-email 2.7.4 X-TM-AS-MML: disable x-cbid: 17102305-0008-0000-0000-000004A2C86C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17102305-0009-0000-0000-00001E352BFD Message-Id: <1508734868-29392-1-git-send-email-kamalesh@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-23_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710230072 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move the search for instruction dead_end into helper function __add_dead_ends(), instead of duplicating the search for unreachable and reachable sections in add_dead_ends(). Cc: Ingo Molnar Signed-off-by: Kamalesh Babulal --- tools/objtool/check.c | 108 +++++++++++++++++++++++--------------------------- 1 file changed, 50 insertions(+), 58 deletions(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index c0e26ad1fa7e..c82966b3ad96 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -303,36 +303,23 @@ static int decode_instructions(struct objtool_file *file) return ret; } -/* - * Mark "ud2" instructions and manually annotated dead ends. - */ -static int add_dead_ends(struct objtool_file *file) +static int __add_dead_ends(struct objtool_file *file, struct section *sec, + bool unreachable_sec) { - struct section *sec; - struct rela *rela; + char warn_str[12] = "unreachable"; struct instruction *insn; + struct rela *rela; bool found; - /* - * By default, "ud2" is a dead end unless otherwise annotated, because - * GCC 7 inserts it for certain divide-by-zero cases. - */ - for_each_insn(file, insn) - if (insn->type == INSN_BUG) - insn->dead_end = true; - - /* - * Check for manually annotated dead ends. - */ - sec = find_section_by_name(file->elf, ".rela.discard.unreachable"); - if (!sec) - goto reachable; + if (!unreachable_sec) + strcpy(warn_str, "reachable"); list_for_each_entry(rela, &sec->rela_list, list) { if (rela->sym->type != STT_SECTION) { - WARN("unexpected relocation symbol type in %s", sec->name); + WARN("Unexpected relocation symbol type in %s", sec->name); return -1; } + insn = find_insn(file, rela->sym->sec, rela->addend); if (insn) insn = list_prev_entry(insn, list); @@ -346,19 +333,54 @@ static int add_dead_ends(struct objtool_file *file) } if (!found) { - WARN("can't find unreachable insn at %s+0x%x", - rela->sym->sec->name, rela->addend); + WARN("can't find %s insn at %s+0x%x", + warn_str, rela->sym->sec->name, + rela->addend); return -1; } } else { - WARN("can't find unreachable insn at %s+0x%x", - rela->sym->sec->name, rela->addend); + WARN("can't find %s insn at %s+0x%x", + warn_str, rela->sym->sec->name, rela->addend); return -1; } - insn->dead_end = true; + /* + * reachable section's insn->dead_end are false. + */ + insn->dead_end = unreachable_sec; } + return 0; +} + +/* + * Mark "ud2" instructions and manually annotated dead ends. + */ +static int add_dead_ends(struct objtool_file *file) +{ + struct section *sec; + struct instruction *insn; + int ret; + + /* + * By default, "ud2" is a dead end unless otherwise annotated, because + * GCC 7 inserts it for certain divide-by-zero cases. + */ + for_each_insn(file, insn) + if (insn->type == INSN_BUG) + insn->dead_end = true; + + /* + * Check for manually annotated dead ends. + */ + sec = find_section_by_name(file->elf, ".rela.discard.unreachable"); + if (!sec) + goto reachable; + + ret = __add_dead_ends(file, sec, true); + if (ret == -1) + return ret; + reachable: /* * These manually annotated reachable checks are needed for GCC 4.4, @@ -370,38 +392,8 @@ static int add_dead_ends(struct objtool_file *file) if (!sec) return 0; - list_for_each_entry(rela, &sec->rela_list, list) { - if (rela->sym->type != STT_SECTION) { - WARN("unexpected relocation symbol type in %s", sec->name); - return -1; - } - insn = find_insn(file, rela->sym->sec, rela->addend); - if (insn) - insn = list_prev_entry(insn, list); - else if (rela->addend == rela->sym->sec->len) { - found = false; - list_for_each_entry_reverse(insn, &file->insn_list, list) { - if (insn->sec == rela->sym->sec) { - found = true; - break; - } - } - - if (!found) { - WARN("can't find reachable insn at %s+0x%x", - rela->sym->sec->name, rela->addend); - return -1; - } - } else { - WARN("can't find reachable insn at %s+0x%x", - rela->sym->sec->name, rela->addend); - return -1; - } - - insn->dead_end = false; - } - - return 0; + ret = __add_dead_ends(file, sec, false); + return ret; } /* -- 2.7.4