From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 4 May 2001 03:30:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 4 May 2001 03:30:40 -0400 Received: from pizda.ninka.net ([216.101.162.242]:24712 "EHLO pizda.ninka.net") by vger.kernel.org with ESMTP id ; Fri, 4 May 2001 03:30:34 -0400 From: "David S. Miller" MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15090.23187.739430.925103@pizda.ninka.net> Date: Fri, 4 May 2001 00:30:27 -0700 (PDT) To: Abramo Bagnara Cc: David Woodhouse , Geert Uytterhoeven , Linux Kernel Development Subject: Re: unsigned long ioremap()? In-Reply-To: <3AF25700.19889930@alsa-project.org> In-Reply-To: <3AF10E80.63727970@alsa-project.org> <15089.979.650927.634060@pizda.ninka.net> <11718.988883128@redhat.com> <3AF12B94.60083603@alsa-project.org> <15089.63036.52229.489681@pizda.ninka.net> <3AF25700.19889930@alsa-project.org> X-Mailer: VM 6.75 under 21.1 (patch 13) "Crater Lake" XEmacs Lucid Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Abramo Bagnara writes: > it's perfectly fine to have: > > regs = (struct reg *) ioremap(addr, size); > foo = readl((unsigned long)®s->bar); > I don't see how one can find this valid compared to my preference of just plain readl(®s->bar); You're telling me it's nicer to have the butt ugly cast there which serves no purpose? One could argue btw that structure offsets are less error prone to code than register offset defines out the wazoo. I think your argument here is bogus. Later, David S. Miller davem@redhat.com