From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932381AbdJZOEU (ORCPT ); Thu, 26 Oct 2017 10:04:20 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:34452 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234AbdJZOES (ORCPT ); Thu, 26 Oct 2017 10:04:18 -0400 X-IronPort-AV: E=Sophos;i="5.43,434,1503331200"; d="scan'208";a="60195382" From: Bart Van Assche To: "keescook@chromium.org" CC: "linux-kernel@vger.kernel.org" , "jiangyilism@gmail.com" , "nab@linux-iscsi.org" , "viro@zeniv.linux.org.uk" , "Jason@zx2c4.com" , "linux-scsi@vger.kernel.org" , "target-devel@vger.kernel.org" , "varun@chelsio.com" Subject: Re: [PATCH] iscsi-target: Convert timers to use timer_setup() Thread-Topic: [PATCH] iscsi-target: Convert timers to use timer_setup() Thread-Index: AQHTTXhJDdyLuqetZUaRBbaK0I93wqL0gkiAgAAY24CAAA6wgIABIwiAgABeyoA= Date: Thu, 26 Oct 2017 14:04:13 +0000 Message-ID: <1509026649.13829.0.camel@wdc.com> References: <20171025100145.GA144703@beast> <1508943795.4165.18.camel@wdc.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [62.168.35.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1533;20:Og6Epb2FHxBNh2+T8bKhMmnpZrcEcEnMX3CfTYT/BwT4+XL/H5ePRMjscPzqHG6jQpkX6GFTcAVfOsIIaVoo42K0xq8Sk8Uo4AlaUox2jdItsXwbnDxeKSTHpLotfJEblRrzwnU7O2gMfVJ5wqEXukZemDtk4YJ2FBa6LXNRSkE= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 2c905b72-f0da-4d52-34c5-08d51c7a7049 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:CY1PR0401MB1533; x-ms-traffictypediagnostic: CY1PR0401MB1533: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(3231020)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1533;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1533; x-forefront-prvs: 04724A515E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(39860400002)(376002)(189002)(377424004)(199003)(24454002)(8936002)(3280700002)(3660700001)(81156014)(81166006)(2906002)(5660300001)(6916009)(2950100002)(39060400002)(4326008)(229853002)(54356999)(86362001)(97736004)(50986999)(2501003)(66066001)(76176999)(6116002)(102836003)(3846002)(53546010)(4001150100001)(106356001)(105586002)(36756003)(103116003)(14454004)(2351001)(54906003)(101416001)(316002)(8676002)(6506006)(25786009)(1730700003)(6436002)(93886005)(77096006)(6486002)(2900100001)(53936002)(6306002)(68736007)(6512007)(99286003)(305945005)(7736002)(478600001)(72206003)(5640700003)(189998001)(33646002)(6246003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1533;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <80E67E432D1DC74E9BF1DAE10E0E09A4@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c905b72-f0da-4d52-34c5-08d51c7a7049 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2017 14:04:13.7289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1533 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9QE4Q0i013782 On Thu, 2017-10-26 at 10:24 +0200, Kees Cook wrote: > On Wed, Oct 25, 2017 at 5:03 PM, Bart Van Assche wrote: > > On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote: > > > However, maintainers: sorry to send this one -- it can't be merged > > > yet, this uses timer_setup_on_stack() which is only in -next right > > > now. If it looks okay, though, I can carry this in the timer tree. > > > > Hello Kees, > > > > Can you have a look at the following patch and queue it before your > > patch if you think this would be useful (this patch has been tested): > > "target/iscsi: Simplify timer manipulation code" > > (https://www.spinics.net/lists/target-devel/msg15385.html). > > This looks good, yeah. Can you resend it with me CCed? It doesn't look > like it was CCed to lkml, so it's not easy to for me to add it to me > tree. OK, I will resend that patch as a reply to this e-mail. BTW, I just finished retesting that patch on top of v4.14-rc6. Bart.