mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: "Svenning Soerensen" <svenning@post5.tele.dk>
Cc: <linux-kernel@vger.kernel.org>, <linux-ipsec@freeswan.org>
Subject: Re: Problem with PMTU discovery on ICMP packets
Date: Sat, 5 May 2001 04:44:44 -0700 (PDT)	[thread overview]
Message-ID: <15091.59308.315685.312632@pizda.ninka.net> (raw)
In-Reply-To: <015201c0d557$a1e69c50$1400a8c0@sss.intermate.com>
In-Reply-To: <015201c0d557$a1e69c50$1400a8c0@sss.intermate.com>


Svenning Soerensen writes:
 > I think there is a bug in the 2.4 icmp code regarding PMTU discovery.
 > It seems to be inconsistent between reboots: at one boot echo replies always
 > have the DF bit set, while after another boot they don't, indicating that
 > this is caused by an uninitialized parameter.
 > Even 'echo 1 > /proc/sys/net/ipv4/ip_no_pmtu_disc' doesn't change this
 > behaviour.
 > 
 > I can't think of any legitimate reasons for doing PMTU discovery on ICMP
 > packets, and since it actually in some situations breaks ping in combination
 > with FreeS/WAN (I can elaborate, if anyone is interested), I would suggest
 > to turn it off in a consistent manner.
 > The patch below (against 2.4.4) should accomplish this.

I want to understand why on some boots it's on while on some
boots it is off, that makes no sense.

Before the piece of code you patched, we call ops->create() which is
inet_create in net/ipv4/af_inet.c, there is sets the PMTU discovery
disposition based upon the setting in ipv4_config which should always
have the same setting at the point during boot, every boot.

You need to figure out why it sometimes gets set and sometimes does
not, then we can figure out how to fix it.

Later,
David S. Miller
davem@redhat.com

  reply	other threads:[~2001-05-05 11:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-05 11:36 Svenning Soerensen
2001-05-05 11:44 ` David S. Miller [this message]
2001-05-05 14:23   ` Svenning Soerensen
2001-05-05 22:11   ` David S. Miller
2001-05-07  0:19     ` Svenning Soerensen
2001-05-10  1:21     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15091.59308.315685.312632@pizda.ninka.net \
    --to=davem@redhat.com \
    --cc=linux-ipsec@freeswan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=svenning@post5.tele.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®