From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbdJ2F4A (ORCPT ); Sun, 29 Oct 2017 01:56:00 -0400 Received: from m12-15.163.com ([220.181.12.15]:45573 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbdJ2Fz5 (ORCPT ); Sun, 29 Oct 2017 01:55:57 -0400 From: Pan Bian To: Patrik Jakobsson , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Pan Bian Subject: gma500: mmu: unmap the correct address Date: Sun, 29 Oct 2017 13:55:12 +0800 Message-Id: <1509256512-5962-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: D8CowACnS4dIbfVZH1OeJA--.44631S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XrWrGFW8XF1fGry7KryxAFb_yoW3uFc_uF 47X397WryYkFn3X3W7AFs2vryIk3W5Zrs7Gayjya4ftw13Zw4xZayv9FyUWry8Jay7GFWD Gw4vgFyrZF43GjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnnSdDUUUUU== X-Originating-IP: [1.202.77.139] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/1tbiVAuAclUMCEZnPQAAsg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function kunmap_atomatic() is called on the same variable twice, i.e. pt->v. In the second call, its parameter should be variable v rather than pt->v. Signed-off-by: Pan Bian --- drivers/gpu/drm/gma500/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c index 0eaf11c..ccb161c 100644 --- a/drivers/gpu/drm/gma500/mmu.c +++ b/drivers/gpu/drm/gma500/mmu.c @@ -395,7 +395,7 @@ static void psb_mmu_pt_unmap_unlock(struct psb_mmu_pt *pt) psb_mmu_clflush(pd->driver, (void *)&v[pt->index]); atomic_set(&pd->driver->needs_tlbflush, 1); } - kunmap_atomic(pt->v); + kunmap_atomic(v); spin_unlock(&pd->driver->lock); psb_mmu_free_pt(pt); return; -- 1.9.1