From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751615AbdJ2N57 (ORCPT ); Sun, 29 Oct 2017 09:57:59 -0400 Received: from m12-16.163.com ([220.181.12.16]:52284 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdJ2N54 (ORCPT ); Sun, 29 Oct 2017 09:57:56 -0400 From: Pan Bian To: "David S. Miller" , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Pan Bian Subject: net: lapbether: fix double free Date: Sun, 29 Oct 2017 21:57:22 +0800 Message-Id: <1509285442-24312-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: EMCowABXccxE3vVZ00NVFQ--.65226S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wry8KrWrWFWDAr13uFyUKFg_yoW3Xrc_Ka nruFsxXrWkt3Wjg3W5CFs3Zr9xK3WkXr4FvF42q39avrW7ZrWrZr1xZryfArWa9rW5AFy5 Kw13ZF17t3yjgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU06VbPUUUUU== X-Originating-IP: [1.202.77.139] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/xtbBZAaAclQG+I2uDwAAsW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function netdev_priv() returns the private data of the device. The memory to store the private data is allocated in alloc_netdev() and is released in netdev_free(). Calling kfree() on the return value of netdev_priv() after netdev_free() results in a double free bug. Signed-off-by: Pan Bian --- drivers/net/wan/lapbether.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c index 63f7490..0e3f8ed 100644 --- a/drivers/net/wan/lapbether.c +++ b/drivers/net/wan/lapbether.c @@ -346,7 +346,6 @@ static int lapbeth_new_device(struct net_device *dev) fail: dev_put(dev); free_netdev(ndev); - kfree(lapbeth); goto out; } -- 1.9.1