From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbdJ2Og4 (ORCPT ); Sun, 29 Oct 2017 10:36:56 -0400 Received: from m12-18.163.com ([220.181.12.18]:34914 "EHLO m12-18.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbdJ2Ogy (ORCPT ); Sun, 29 Oct 2017 10:36:54 -0400 From: Pan Bian To: Yisen Zhuang , Salil Mehta , "David S. Miller" , lipeng , Kejian Yan , Lin Yun Sheng , Tobias Klauser , Arnd Bergmann Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: net: hns: set correct return value Date: Sun, 29 Oct 2017 22:35:32 +0800 Message-Id: <1509287732-32172-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: EsCowAA3LH015_VZSql7BQ--.59356S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrKryxCFWfuF1xXw1kZr4fKrg_yoWkXFb_u3 y29FyxJr4rKr1kKa1fW39xCry2kF40qw1kua1I9rZIkw13Cr15Ja4rXr10kr1kWw10vr90 9rnay3WSvF9FqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnr9NDUUUUU== X-Originating-IP: [1.202.77.139] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/1tbiNhiAclWBX6UWbAAAsI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function of_parse_phandle() returns a NULL pointer if it cannot resolve a phandle property to a device_node pointer. In function hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract the error code. However, in this case, the extracted error code will always be zero, which is unexpected. Signed-off-by: Pan Bian --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index 3652063..e771926 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c @@ -2369,8 +2369,8 @@ static int hns_nic_dev_probe(struct platform_device *pdev) priv->enet_ver = AE_VERSION_2; ae_node = of_parse_phandle(dev->of_node, "ae-handle", 0); - if (IS_ERR_OR_NULL(ae_node)) { - ret = PTR_ERR(ae_node); + if (!ae_node) { + ret = -ENODEV; dev_err(dev, "not find ae-handle\n"); goto out_read_prop_fail; } -- 1.9.1