From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753920AbdJaRQj (ORCPT ); Tue, 31 Oct 2017 13:16:39 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:13215 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbdJaRQf (ORCPT ); Tue, 31 Oct 2017 13:16:35 -0400 X-IronPort-AV: E=Sophos;i="5.44,325,1505750400"; d="scan'208";a="163101907" From: Bart Van Assche To: "keescook@chromium.org" CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "varun@chelsio.com" , "target-devel@vger.kernel.org" , "jiangyilism@gmail.com" , "nab@linux-iscsi.org" Subject: Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup() Thread-Topic: [PATCH v2] target/iscsi: Convert timers to use timer_setup() Thread-Index: AQHTTwS2A/LKCVfRgEmiJimW978EV6L3qCuAgAVxhgCAASA7gA== Date: Tue, 31 Oct 2017 17:16:26 +0000 Message-ID: <1509470185.12927.1.camel@wdc.com> References: <20171027091930.GA14728@beast> <1509109031.3135.1.camel@wdc.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;20:LV2VxE3lUC/0WKF14FgCtdAZmxz+GnOsExKf2NMjXH4GjXY0g4MiX08Toz3RBaKU8UyKQLssV298BUzUCbHz5lFQ2DCeP9gWfd1VYKwS6DVYQg5Y36ZP3YNhdPKiUY+g9/Tz9ga+bRIy5Z+CqOVqX82rc1zlHdHFa3Hv37Cv6N0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 37b8414b-9821-4a10-10d7-08d520831e60 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(48565401081)(2017052603199);SRVR:CY1PR0401MB1536; x-ms-traffictypediagnostic: CY1PR0401MB1536: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:(84791874153150); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(3231020)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1536; x-forefront-prvs: 04772EA191 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(376002)(346002)(189002)(377424004)(24454002)(199003)(33646002)(53936002)(36756003)(97736004)(99286003)(54356999)(25786009)(4326008)(478600001)(6306002)(189998001)(6512007)(3846002)(6116002)(102836003)(8676002)(54906003)(4001150100001)(81166006)(81156014)(316002)(1730700003)(86362001)(2501003)(7736002)(68736007)(305945005)(72206003)(3660700001)(2906002)(5660300001)(2900100001)(229853002)(3280700002)(76176999)(53546010)(966005)(8936002)(50986999)(105586002)(66066001)(6246003)(14454004)(39060400002)(2351001)(5640700003)(101416001)(2950100002)(103116003)(6916009)(106356001)(77096006)(6486002)(6436002)(6506006);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <5E0796C106C4694889FA563329B3FBDA@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37b8414b-9821-4a10-10d7-08d520831e60 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2017 17:16:26.3803 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9VHGis6019186 On Mon, 2017-10-30 at 17:04 -0700, Kees Cook wrote: > On Fri, Oct 27, 2017 at 5:57 AM, Bart Van Assche wrote: > > On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote: > > > In preparation for unconditionally passing the struct timer_list pointer to > > > all timer callbacks, switch to using the new timer_setup() and from_timer() > > > to pass the timer pointer explicitly. Includes a fix for correcting an > > > on-stack timer usage. > > > > These changes look good to me but I would like to test this patch. Is there > > a tree available somewhere that includes this patch? > > I didn't, but in case it's easier to test, I have put it up here, > which is just tip/timers/core with the two target timer patches on > top: > > https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=kspp/timer/tip/target Hello Kees, That tree passed the iSCSI target tests I ran so feel free to add my Reviewed-by and Tested-by to [PATCH v2] target/iscsi: Convert timers to use timer_setup(). Bart.