From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "roman.penyaev@profitbricks.com" <roman.penyaev@profitbricks.com>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>, "axboe@fb.com" <axboe@fb.com>
Subject: Re: [PATCH 1/1] [RFC] blk-mq: fix queue stalling on shared hctx restart
Date: Wed, 1 Nov 2017 16:50:45 +0000 [thread overview]
Message-ID: <1509555044.2530.35.camel@wdc.com> (raw)
In-Reply-To: <CAJrWOzAmPT_0jrYRi_U-fHHjOitk2XE461ZhL=aKFiY3iQjGMQ@mail.gmail.com>
On Mon, 2017-10-23 at 17:12 +0200, Roman Penyaev wrote:
> On Fri, Oct 20, 2017 at 10:05 PM, Bart Van Assche wrote:
> > Commit 6d8c6c0f97ad is something I came up with to fix queue lockups in the
> > SCSI and dm-mq drivers.
>
> You mean fairness? (some hctx get less amount of chances to be restarted).
> That's why you need to restart them in RR fashion, right?
Commit 6d8c6c0f97ad not only improved fairness but also fixed a lockup scenario.
After a driver tag has been freed not only the hw queues of the request queue for
which a request completed must be reexamined but also the hw queues associated
with the other request queues that share the same tag set.
Bart.
next prev parent reply other threads:[~2017-11-01 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 10:22 Roman Pen
2017-10-19 17:47 ` Bart Van Assche
2017-10-20 9:39 ` Roman Penyaev
2017-10-20 20:05 ` Bart Van Assche
2017-10-23 15:12 ` Roman Penyaev
2017-11-01 16:50 ` Bart Van Assche [this message]
[not found] ` <20171020133943.GA31275@ming.t460p>
2017-10-23 16:12 ` Roman Penyaev
2017-10-24 10:04 ` Ming Lei
2017-11-07 15:54 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509555044.2530.35.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@fb.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roman.penyaev@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®