From: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Julien Boibessot" <julien.boibessot@armadeus.com>,
"Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Subject: [PATCH 3/3] HID: cp2112: fix broken gpio_direction_input callback
Date: Thu, 2 Nov 2017 12:12:44 +0100 [thread overview]
Message-ID: <1509621164-28830-3-git-send-email-sebastien.szymanski@armadeus.com> (raw)
In-Reply-To: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com>
When everything goes smoothly, ret is set to 0 which makes the function
to return EIO error.
Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling")
Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
drivers/hid/hid-cp2112.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index 28e3c18..f7754a6 100644
--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c
@@ -205,12 +205,13 @@ static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
ret = hid_hw_raw_request(hdev, CP2112_GPIO_CONFIG, buf,
CP2112_GPIO_CONFIG_LENGTH, HID_FEATURE_REPORT,
HID_REQ_SET_REPORT);
- if (ret < 0) {
+ if (ret != CP2112_GPIO_CONFIG_LENGTH) {
hid_err(hdev, "error setting GPIO config: %d\n", ret);
goto exit;
}
- ret = 0;
+ mutex_unlock(&dev->lock);
+ return 0;
exit:
mutex_unlock(&dev->lock);
--
2.7.3
next prev parent reply other threads:[~2017-11-02 12:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:12 [PATCH 1/3] HID: cp2112: fix interface specification URL Sébastien Szymanski
2017-11-02 11:12 ` [PATCH 2/3] HID: cp2112: add HIDRAW dependency Sébastien Szymanski
2017-11-06 8:12 ` Benjamin Tissoires
2017-11-02 11:12 ` Sébastien Szymanski [this message]
2017-11-06 8:11 ` [PATCH 3/3] HID: cp2112: fix broken gpio_direction_input callback Benjamin Tissoires
2017-11-06 13:58 ` Sébastien Szymanski
2017-11-06 17:43 ` Benjamin Tissoires
2017-11-09 11:45 ` [PATCH 1/3] HID: cp2112: fix interface specification URL Jiri Kosina
2017-11-10 9:05 ` Sébastien Szymanski
2017-11-10 10:04 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509621164-28830-3-git-send-email-sebastien.szymanski@armadeus.com \
--to=sebastien.szymanski@armadeus.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=julien.boibessot@armadeus.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®