From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751134AbdKEOcD (ORCPT ); Sun, 5 Nov 2017 09:32:03 -0500 Received: from m12-16.163.com ([220.181.12.16]:55896 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbdKEOcB (ORCPT ); Sun, 5 Nov 2017 09:32:01 -0500 From: Pan Bian To: Matthew Wilcox , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH] scsi: advansys: fix improper function call to kfree Date: Sun, 5 Nov 2017 22:30:12 +0800 Message-Id: <1509892212-10489-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: EMCowACXcbx1IP9ZuaUhGQ--.7323S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7WryUCF47KF47WF48Wry8Zrb_yoW3Crb_uw 4Igr92kryDGF1xKw1fArW7Zry0ka1UX3ZYvr1Sq34ayryUZw45J3WS9r1rZrsrGF40yw1D ur1qv34fAw10kjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnI387UUUUU== X-Originating-IP: [1.202.77.139] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/1tbiQBeHclSIT1re0QAAsk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In function advansys_eisa_probe(), data->host[i] holds the return value of scsi_host_alloc(). The memory allocated by scsi_host_alloc() should be deallocated with scsi_host_put(), not kfree(). Signed-off-by: Pan Bian --- drivers/scsi/advansys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 24e57e7..1f56a6d 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -11678,8 +11678,8 @@ static int advansys_eisa_probe(struct device *dev) return 0; free_data: - kfree(data->host[0]); - kfree(data->host[1]); + scsi_host_put(data->host[0]); + scsi_host_put(data->host[1]); kfree(data); fail: return err; -- 1.9.1