From: "David S. Miller" <davem@redhat.com>
To: trond.myklebust@fys.uio.no
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4.4 linearize UDP RPC requests using GFP_KERNEL...
Date: Fri, 11 May 2001 02:41:45 -0700 (PDT) [thread overview]
Message-ID: <15099.46041.778542.342635@pizda.ninka.net> (raw)
In-Reply-To: <15099.43446.132871.699151@charged.uio.no>
In-Reply-To: <15099.43446.132871.699151@charged.uio.no>
Trond Myklebust writes:
> IMHO allocating the buffer using GFP_ATOMIC is a mistake. As I said
> we're in a thread context, so sleeping in GFP_KERNEL is safe. In
> addition, the cost of dropping the request if we can't allocate the
> buffer is heavy in that the client has to wait for a timeout, and then
> retry.
>
> I'd therefore like to propose the following change.
...
> --- linux-2.4.4/net/sunrpc/svcsock.c.orig Fri Apr 27 23:15:01 2001
> +++ linux-2.4.4/net/sunrpc/svcsock.c Fri May 11 10:08:36 2001
...
> - if (skb_linearize(skb, GFP_ATOMIC) != 0) {
> + if (skb_linearize(skb, GFP_KERNEL) != 0) {
No arguments here.
Later,
David S. Miller
davem@redhat.com
prev parent reply other threads:[~2001-05-11 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-11 8:58 Trond Myklebust
2001-05-11 9:41 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15099.46041.778542.342635@pizda.ninka.net \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®