From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH] clocksource: timer-of: drop __init annotations in timer_*_exit functions
Date: Mon, 6 Nov 2017 14:48:36 +0000 [thread overview]
Message-ID: <1509979716-10646-1-git-send-email-sudeep.holla@arm.com> (raw)
timer_{base,clk,irq}_exit functions have __init annotations. Commit
f48729a999ee ("clocksource/drivers/timer-of: Add timer_of_exit function")
added timer_of_exit to undo what has been done by the timer_of_init()
function, which means we need to drop __init to use timer_*_exit
functions.
It also generates the build time warning:
"WARNING: vmlinux.o: Section mismatch in reference from the
function timer_of_exit() to the variable .init.text:$x
The function timer_of_exit() references the variable __init $x.
This is often because timer_of_exit lacks a __init annotation or the
annotation of $x is wrong."
This patch fixes the above build warning.
Fixes: f48729a999ee ("clocksource/drivers/timer-of: Add timer_of_exit function")
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/clocksource/timer-of.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c
index 7c64a5c1bfc1..701b476ccc7c 100644
--- a/drivers/clocksource/timer-of.c
+++ b/drivers/clocksource/timer-of.c
@@ -24,7 +24,7 @@
#include "timer-of.h"
-static __init void timer_irq_exit(struct of_timer_irq *of_irq)
+static void timer_irq_exit(struct of_timer_irq *of_irq)
{
struct timer_of *to = container_of(of_irq, struct timer_of, of_irq);
@@ -72,7 +72,7 @@ static __init int timer_irq_init(struct device_node *np,
return 0;
}
-static __init void timer_clk_exit(struct of_timer_clk *of_clk)
+static void timer_clk_exit(struct of_timer_clk *of_clk)
{
of_clk->rate = 0;
clk_disable_unprepare(of_clk->clk);
@@ -116,7 +116,7 @@ static __init int timer_clk_init(struct device_node *np,
goto out;
}
-static __init void timer_base_exit(struct of_timer_base *of_base)
+static void timer_base_exit(struct of_timer_base *of_base)
{
iounmap(of_base->base);
}
--
2.7.4
reply other threads:[~2017-11-06 14:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509979716-10646-1-git-send-email-sudeep.holla@arm.com \
--to=sudeep.holla@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®