From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 973852FBDF3 for ; Mon, 10 Nov 2025 11:38:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762774737; cv=none; b=Q/aE/6Y9vBjEcDOdzhhx6maxLToxVHHrACpQup0rYaZs9rI2LewXu8wbJX/JP16Bb42SWuT9TQPIHTtE1bUAOPb5ELXlTN9fhY+nbKtnWBAHa2ncbFD3jDyW2PypKKmjegbAUPJkDW+0MamyF1cOd9tgy04HX6UnW6HQgmEHFfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762774737; c=relaxed/simple; bh=442tawppyk6VW4zUh6UCP/rG01cfIHZsqjC14wtPq6I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bMeiN6wpITs8atRx6+VLogaloL6oTx2sSXR23G/dnvhbzBwUot+ACVK3A4CizASARV4XQYvukhLPtOfLdklVWRVF/TbdNK86MeV/Ah1HGIQIPAoaRbOzglWwdivYVqIYea3Q/yD+EStp0tEZGjXR+wvxWyizoliwOtRtGP+8/no= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aDasOyGa; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aDasOyGa" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4775ae77516so34783225e9.1 for ; Mon, 10 Nov 2025 03:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762774733; x=1763379533; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PDGyqZKTc6nb0bCAbSIQ1bmZ2i6gcCfwYTLcd5wNs/k=; b=aDasOyGavf9cMAYOVFCg8V0Bts9qDcLZ0U4MZWY5IBd1UjKRuD8Bk7J6p3+XsWOZ7J An45SH6ebNL+8/Dgnj6jkLoJ5YCEdMudgRmr4una4/tsPeAfOgJ87uDsdiMsSfTLvoJO GowvWZl8np0p3ky+/Mn3BbXl4i3W1+wtaoMrZissmKo0t3L3DZKDBqcwDq9J2H/vKdOX Z5RBf6E1o8/7TLhawbW2eSvMgzs8v8wTz09bmiem9BAG3elJ4yqHT3ot5GqwBjJ9hp4E fHWXJSKRegWjDFMcMasqoGfifk47kx4mdjO0FX2s2iVifHJF+ei2Iiq3JncykkQLVORs sJoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762774733; x=1763379533; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PDGyqZKTc6nb0bCAbSIQ1bmZ2i6gcCfwYTLcd5wNs/k=; b=JkU8HXOYhC5bkU4Uh/vj3qJ16A3eGIbXtj67eGOH7PAnEwZyrDAe6Tj7z4aYFlRy1X 7PJNSgKHgto8dbZZsAj4CjzEjjtmj2FwSiRKrJZ5LWdZO3GOjJ36gmrjsNz9X0oghPoE M3h6CsIfll41ckZfCcfjA6Hfay+nM60NVKt8akTSSy1fD8LUa1BCMRZMIxtB0UcyQ4SN l+cUxK/vRPT0yD67FJTR4xJV3gHqqpaQS5CGSbrIlbVe3mD7ermicE9VKpBSWzUJYjre rkfPnfpWD7J510qNWVxG1fVTqcWeRyNB5DTDxAgP/Lg+n43XFKmOkGN8SjrYAd9oGZjT D9dA== X-Forwarded-Encrypted: i=1; AJvYcCVFDytTAHzxGdhxXpgb/Vx+z6UDFsWXgoE0XpPTL1dw62I47h3n7gmIStykePu8l1jmUzpc/AD+GkUQ4Jw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7p4mKLyIXXaV9ItfEYm0Yu9DolIp4lmCfGFD9m2d0Rd57j2Ut SAVWIpquY1tBBUU3SuMM2CvF+/Gm1jmKcbWDu8omeCGzjkiRbcBvrswpixidqFpRDYg= X-Gm-Gg: ASbGncvsKj73iJf+2bj9uL1zJnHY//2jBjDjVJF5NCI2BlNx5aIG33CWFd/nzg+L216 ny3KTLX1RsuX6VVNBS50EMAxeROk/zgkvupA5OWVxd5LwxTysASW2GS1P/j98TjL2m5KgRlJnqc bDIe3CabBn83XOxSv1KdIJrm2GvjHEeEsJ9cHE7sj93BgFCzyksIXgc6vzVpHu/S8UITzcwdXWg bo6OtKnXs7kt2afe2/BXrKM8XO9yv90u5/itB0KnV8xD+BrO3ktl3mclt9AgjunN6agOlnsHBhX 6er5dv9kMt11aOksJ0JjAUVsXSAZpAktPfKx0bG75BNm1JubWtgZVAwPZxX9uRHhUdsuryXJhHr rgQ6YPzKWXV1bALjylBEKQ6TZmjAk82Gl2rfkjRvJvP2tmmQwm786LTMiXABVWnypY9VoUVY+Sk TDia1RAJKo73q+DbgWqoMQ3/iPHmAy9FhuAwR+7rbljA== X-Google-Smtp-Source: AGHT+IG+JUAf6UVQVsqEmCn1XhFTq5TWQOptKskoiqVgM/FKW2sNC6jwfwM3QRHOYWASpaXOTouW+A== X-Received: by 2002:a05:600c:4fcb:b0:46e:5b74:4858 with SMTP id 5b1f17b1804b1-477732341e9mr73691505e9.13.1762774732654; Mon, 10 Nov 2025 03:38:52 -0800 (PST) Received: from [192.168.0.21] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4775ce20ee3sm314783285e9.9.2025.11.10.03.38.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Nov 2025 03:38:52 -0800 (PST) Message-ID: <150cee0d-6c5f-4380-8c3b-ff29c4ca679b@linaro.org> Date: Mon, 10 Nov 2025 11:38:51 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 5/8] media: qcom: camss: Initialize lanes after lane configuration is available To: david@ixit.cz, Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , Casey Connolly , "Dr. Git" Cc: Joel Selvaraj , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251109-qcom-cphy-v1-0-165f7e79b0e1@ixit.cz> <20251109-qcom-cphy-v1-5-165f7e79b0e1@ixit.cz> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20251109-qcom-cphy-v1-5-165f7e79b0e1@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/11/2025 09:39, David Heidelberg via B4 Relay wrote: > From: Petr Hodina > > The lanes must not be initialized before the driver has access to > the lane configuration, as it depends on whether D-PHY or C-PHY mode > is in use. Move the lane initialization to a later stage where the > configuration structures are available. > > Signed-off-by: Petr Hodina > Signed-off-by: David Heidelberg > --- > .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 70 ++++++++++++---------- > 1 file changed, 37 insertions(+), 33 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > index 348b8cd18327e..c2adbde6b4e0d 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > @@ -1101,6 +1101,42 @@ static void csiphy_lanes_enable(struct csiphy_device *csiphy, > u8 val; > int i; > > + switch (csiphy->camss->res->version) { > + case CAMSS_845: > + regs->lane_regs = &lane_regs_sdm845[0]; > + regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845); > + break; > + case CAMSS_2290: > + regs->lane_regs = &lane_regs_qcm2290[0]; > + regs->lane_array_size = ARRAY_SIZE(lane_regs_qcm2290); > + break; > + case CAMSS_7280: > + case CAMSS_8250: > + regs->lane_regs = &lane_regs_sm8250[0]; > + regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8250); > + break; > + case CAMSS_8280XP: > + regs->lane_regs = &lane_regs_sc8280xp[0]; > + regs->lane_array_size = ARRAY_SIZE(lane_regs_sc8280xp); > + break; > + case CAMSS_X1E80100: > + case CAMSS_8550: > + regs->offset = 0x1000; > + break; > + case CAMSS_8650: > + regs->lane_regs = &lane_regs_sm8650[0]; > + regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8650); > + regs->offset = 0x1000; > + break; > + case CAMSS_8300: > + case CAMSS_8775P: > + regs->lane_regs = &lane_regs_sa8775p[0]; > + regs->lane_array_size = ARRAY_SIZE(lane_regs_sa8775p); > + break; > + default: > + break; > + } > + > settle_cnt = csiphy_settle_cnt_calc(link_freq, csiphy->timer_clk_rate); > > if (c->cphy) { > @@ -1160,47 +1196,15 @@ static int csiphy_init(struct csiphy_device *csiphy) > return -ENOMEM; > > csiphy->regs = regs; > - regs->offset = 0x800; > > switch (csiphy->camss->res->version) { > - case CAMSS_845: > - regs->lane_regs = &lane_regs_sdm845[0]; > - regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845); > - break; > - case CAMSS_2290: > - regs->lane_regs = &lane_regs_qcm2290[0]; > - regs->lane_array_size = ARRAY_SIZE(lane_regs_qcm2290); > - break; > - case CAMSS_7280: > - case CAMSS_8250: > - regs->lane_regs = &lane_regs_sm8250[0]; > - regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8250); > - break; > - case CAMSS_8280XP: > - regs->lane_regs = &lane_regs_sc8280xp[0]; > - regs->lane_array_size = ARRAY_SIZE(lane_regs_sc8280xp); > - break; > case CAMSS_X1E80100: > - regs->lane_regs = &lane_regs_x1e80100[0]; > - regs->lane_array_size = ARRAY_SIZE(lane_regs_x1e80100); > - regs->offset = 0x1000; > - break; > case CAMSS_8550: > - regs->lane_regs = &lane_regs_sm8550[0]; > - regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8550); > - regs->offset = 0x1000; > - break; > case CAMSS_8650: > - regs->lane_regs = &lane_regs_sm8650[0]; > - regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8650); > regs->offset = 0x1000; > break; > - case CAMSS_8300: > - case CAMSS_8775P: > - regs->lane_regs = &lane_regs_sa8775p[0]; > - regs->lane_array_size = ARRAY_SIZE(lane_regs_sa8775p); > - break; > default: > + regs->offset = 0x800; > break; > } > > Agreement in principle. Reviewed-by: Bryan O'Donoghue