mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: 13145886936@163.com, davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	gushengxian <gushengxian@yulong.com>
Subject: Re: [PATCH] net: appletalk: fix some mistakes in grammar
Date: Mon, 07 Jun 2021 19:32:40 -0700	[thread overview]
Message-ID: <150d317762ebcbe7cb824ba6850bf6dc25ee1c00.camel@perches.com> (raw)
In-Reply-To: <20210608022546.7587-1-13145886936@163.com>

On Mon, 2021-06-07 at 19:25 -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
> 
> Fix some mistakes in grammar.
[]
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
[]
> @@ -707,7 +707,7 @@ static int atif_ioctl(int cmd, void __user *arg)
>  
> 
>  		/*
>  		 * Phase 1 is fine on LocalTalk but we don't do
> -		 * EtherTalk phase 1. Anyone wanting to add it go ahead.
> +		 * EtherTalk phase 1. Anyone wanting to add it goes ahead.

This is really not better grammar.
It's describing how anyone should feel free to create an implementation.

It's also really old code that no one will use much anymore, so any
change to this module isn't particularly useful.



  parent reply	other threads:[~2021-06-08  2:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  2:25 13145886936
2021-06-08  2:31 ` Seth David Schoen
2021-06-08  2:32 ` Joe Perches [this message]
2021-06-08  2:36 ` Randy Dunlap
2021-06-08  4:03 13145886936
2021-06-09  1:52 13145886936
2021-06-09  2:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150d317762ebcbe7cb824ba6850bf6dc25ee1c00.camel@perches.com \
    --to=joe@perches.com \
    --cc=13145886936@163.com \
    --cc=davem@davemloft.net \
    --cc=gushengxian@yulong.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®